Changeset View
Standalone View
Makefile
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= luarocks | PORTNAME= luarocks | ||||
matUnsubmitted Not Done Inline Actionsmat: ```
DISTVERSION= 3.0.0beta2
``` | |||||
Not Done Inline ActionsThis is in the wrong order. Also, use DISTVERSION=3.0.0beta2. mat: This is in the wrong order. Also, use `DISTVERSION=3.0.0beta2`. | |||||
Not Done Inline ActionsThis should be reverted to the previous USE_GITHUB=yes; the GH_ACCOUNT and GH_PROJECT defaults are good here now [1] kevans: This should be reverted to the previous USE_GITHUB=yes; the GH_ACCOUNT and GH_PROJECT defaults… | |||||
Not Done Inline ActionsIt looks like the direct github download contains a bunch of useless-to-us windows DLLs that really bloats the file; 5 meg rather than 200k. andrew_tao173.riddles.org.uk: It looks like the direct github download contains a bunch of useless-to-us windows DLLs that… | |||||
Not Done Inline ActionsI'll defer to @mat or any other ports person on that... I don't know if the space savings outweighs the benefit of, e.g. the multiple MASTER_SITES that come along with USE_GITHUB. kevans: I'll defer to @mat or any other ports person on that... I don't know if the space savings… | |||||
Not Done Inline ActionsThere are no multiple MASTER_SITES when using USE_GITHUB, so not sure what you are talking about. Our policy is to always use the official distribution file provided by the projects if they are available. mat: There are no multiple MASTER_SITES when using USE_GITHUB, so not sure what you are talking… | |||||
Not Done Inline ActionsClearly misremembering- for some reason I thought there was more than just https://codeload.github.com kevans: Clearly misremembering- for some reason I thought there was more than just https://codeload. | |||||
Not Done Inline ActionsIs there any policy on preferring https to http? andrew_tao173.riddles.org.uk: Is there any policy on preferring https to http? | |||||
Not Done Inline ActionsUntil the end of 8.3 (or maybe 8.4) support, we needed http master sites because fetch's proxy feature did not include https support. mat: Until the end of 8.3 (or maybe 8.4) support, we needed http master sites because fetch's proxy… | |||||
PORTVERSION= 2.4.3 | PORTREVISION= 0 | ||||
DISTVERSIONPREFIX= v | DISTVERSION= 3.0.0 | ||||
CATEGORIES= devel | CATEGORIES= devel | ||||
MASTER_SITES= http://luarocks.github.io/luarocks/releases/ | |||||
PKGNAMEPREFIX= ${LUA_PKGNAMEPREFIX} | PKGNAMEPREFIX= ${LUA_PKGNAMEPREFIX} | ||||
MAINTAINER= jbeich@FreeBSD.org | MAINTAINER= jbeich@FreeBSD.org | ||||
COMMENT= Package manager for Lua modules | COMMENT= Package manager for Lua modules | ||||
LICENSE= MIT | LICENSE= MIT | ||||
LICENSE_FILE= ${WRKSRC}/COPYING | LICENSE_FILE= ${WRKSRC}/COPYING | ||||
RUN_DEPENDS= zip:archivers/zip \ | RUN_DEPENDS= zip:archivers/zip \ | ||||
curl:ftp/curl | curl:ftp/curl | ||||
USE_GITHUB= yes | |||||
GH_ACCOUNT= keplerproject | |||||
NO_ARCH= yes | NO_ARCH= yes | ||||
HAS_CONFIGURE= yes | HAS_CONFIGURE= yes | ||||
CONFIGURE_ARGS= --prefix=${PREFIX} \ | CONFIGURE_ARGS= --prefix=${PREFIX} \ | ||||
--with-lua-include=${LUA_INCDIR} \ | --with-lua-include=${LUA_INCDIR} \ | ||||
--lua-version=${LUA_VER} \ | --lua-version=${LUA_VER} \ | ||||
--with-downloader=curl \ | |||||
--versioned-rocks-dir | --versioned-rocks-dir | ||||
ALL_TARGET= build | ALL_TARGET= build | ||||
OPTIONS_DEFINE= LUAJIT | OPTIONS_DEFINE= LUAJIT | ||||
Not Done Inline ActionsThis does not do what you think it does. Remove the commented out line. mat: This does not do what you think it does. Remove the commented out line. | |||||
Not Done Inline ActionsThere is no previous value for USES, this should probably be USES= kevans: There is no previous value for `USES`, this should probably be `USES=` | |||||
Not Done Inline ActionsAlso, it is badly placed, see Chapter 15. Order of Variables in Port Makefiles. mat: Also, it is badly placed, see [[ https://www.freebsd.org/doc/en/books/porters-handbook/porting… | |||||
LUAJIT_DESC= Use LuaJIT instead of Lua | LUAJIT_DESC= Use LuaJIT instead of Lua | ||||
LUAJIT_BUILD_DEPENDS= luajit:lang/luajit | LUAJIT_BUILD_DEPENDS= luajit:lang/luajit | ||||
LUAJIT_RUN_DEPENDS= luajit:lang/luajit | LUAJIT_RUN_DEPENDS= luajit:lang/luajit | ||||
LUAJIT_CONFIGURE_ON= --lua-suffix=jit | LUAJIT_CONFIGURE_ON= --lua-suffix=jit | ||||
LUAJIT_PLIST_SUB= LUA_VER=${LUA_VER} \ | LUAJIT_PLIST_SUB= LUA_VER=${LUA_VER} \ | ||||
LUA_MODSHAREDIR=share/lua/${LUA_VER} | LUA_MODSHAREDIR=share/lua/${LUA_VER} | ||||
LUAJIT_VARS= LUA_INCDIR=${LOCALBASE}/include/luajit-2.0 \ | LUAJIT_VARS= LUA_INCDIR=${LOCALBASE}/include/luajit-2.0 \ | ||||
LUA_VER=5.1 LUA_PKGNAMEPREFIX=lua51- | LUA_VER=5.1 LUA_PKGNAMEPREFIX=lua51- | ||||
LUAJIT_USES_OFF= lua | LUAJIT_USES_OFF= lua | ||||
post-patch: | post-patch: | ||||
# Don't install unprefixed binaries to avoid package conflict with | |||||
# luarocks built against different lang/lua* versions | |||||
@${REINPLACE_CMD} '/ln -/d' ${WRKSRC}/Makefile.install.inc | |||||
Not Done Inline ActionsMk/bsd.port.mk has still cruft left after staging support was added. ${INSTALL_*} commands try to enforce user/group and permissions but non-default values are no longer recommended after CHANGES@20140922. As INSTALL_AS_USER isn't set by default the installed files will be always owned by root/wheel while permissions are subject to the default umask (i.e., 022). So, the only real change here is the removal of write permission for owner. Given the vast majority of ports don't do this I'm not sure what's the benefit given the maintenance cost. jbeich: Mk/bsd.port.mk has still cruft left after staging support was added. `${INSTALL_*}` commands… | |||||
post-build: | post-build: | ||||
# NO_ARCH requires https://bugs.archlinux.org/task/40388 | |||||
@${REINPLACE_CMD} -e '/LUAROCKS_UNAME_M/d' \ | |||||
${WRKSRC}/src/luarocks/site_config.lua | |||||
Not Done Inline ActionsIf those targets are now empty, please remove them. mat: If those targets are now empty, please remove them. | |||||
Not Done Inline ActionsThose targets are empty, please remove them. mat: Those targets are empty, please remove them. | |||||
.include <bsd.port.mk> | .include <bsd.port.mk> |