Changeset View
Changeset View
Standalone View
Standalone View
stand/i386/zfsboot/Makefile
| Show All 23 Lines | CFLAGS+=-DBOOTPROG=\"zfsboot\" \ | ||||
| -DSIOFMT=${B2SIOFMT} \ | -DSIOFMT=${B2SIOFMT} \ | ||||
| -DSIOSPD=${BOOT_COMCONSOLE_SPEED} \ | -DSIOSPD=${BOOT_COMCONSOLE_SPEED} \ | ||||
| -I${LDRSRC} \ | -I${LDRSRC} \ | ||||
| -I${BOOTSRC}/i386/common \ | -I${BOOTSRC}/i386/common \ | ||||
| -I${BOOTSRC}/i386 \ | -I${BOOTSRC}/i386 \ | ||||
| -I${ZFSSRC} \ | -I${ZFSSRC} \ | ||||
| -I${SYSDIR}/crypto/skein \ | -I${SYSDIR}/crypto/skein \ | ||||
| -I${SYSDIR}/cddl/boot/zfs \ | -I${SYSDIR}/cddl/boot/zfs \ | ||||
| -I${SYSDIR}/contrib/zstd/lib \ | |||||
imp: We don't need this in every single Makefile, do we? Can't we centralize this and expand flags… | |||||
Not Done Inline Actionsactually we could have something like: CFLAGS.somefile.c += ... tsoome: actually we could have something like:
CFLAGS.somefile.c += ... | |||||
| -I${BOOTSRC}/i386/boot2 \ | -I${BOOTSRC}/i386/boot2 \ | ||||
| -Wall -Waggregate-return -Wbad-function-cast -Wno-cast-align \ | -Wall -Waggregate-return -Wbad-function-cast -Wno-cast-align \ | ||||
| -Wmissing-declarations -Wmissing-prototypes -Wnested-externs \ | -Wmissing-declarations -Wmissing-prototypes -Wnested-externs \ | ||||
| -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings | -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings | ||||
| CFLAGS.gcc+= --param max-inline-insns-single=100 | CFLAGS.gcc+= --param max-inline-insns-single=100 | ||||
| LD_FLAGS+=${LD_FLAGS_BIN} | LD_FLAGS+=${LD_FLAGS_BIN} | ||||
| ▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines | |||||
We don't need this in every single Makefile, do we? Can't we centralize this and expand flags here for ZFS? We already have 4 lines for it, which is 3 too many.