Page MenuHomeFreeBSD
Differential D14769 Diff 40497 stand/efi/loader/bootinfo.c

Changeset View

Standalone View

View Options

stand/efi/loader/bootinfo.c

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Linesbi_load_efi_data(struct preloaded_file *kfp)
const char *efi_novmap; const char *efi_novmap;
size_t efisz; size_t efisz;
UINTN efi_mapkey; UINTN efi_mapkey;
UINTN mmsz, pages, retry, sz; UINTN mmsz, pages, retry, sz;
UINT32 mmver; UINT32 mmver;
struct efi_map_header *efihdr; struct efi_map_header *efihdr;
bool do_vmap; bool do_vmap;
#if defined(__amd64__) || defined(__aarch64__) #if defined(__amd64__) || defined(__aarch64__)
impUnsubmitted
Not Done
Inline Actions

Isn't this true also of armv7 and i386?

imp: Isn't this true also of armv7 and i386?
kevansAuthorUnsubmitted
Not Done
Inline Actions

I'd have to double-check- that might now be true of all arch's that will compile EFI bits by default. I think @manu had recently stubbed out the struct efi_fb for armv7 at least.

kevans: I'd have to double-check- that might now be true of all arch's that will compile EFI bits by…
manuUnsubmitted
Not Done
Inline Actions

Yeah armv7 and arm64 have the efi_fb in metadata.h (even if efifb still doesn't work).

manu: Yeah armv7 and arm64 have the efi_fb in metadata.h (even if efifb still doesn't work).
struct efi_fb efifb; struct efi_fb efifb;
if (efi_find_framebuffer(&efifb) == 0) { efi_reset_framebuffer();
impUnsubmitted
Not Done
Inline Actions

We should check the return status here and avoid calling efi_find_framebuffer()

imp: We should check the return status here and avoid calling efi_find_framebuffer()
if (efi_find_framebuffer(&efifb, NULL) == 0) {
printf("EFI framebuffer information:\n"); printf("EFI framebuffer information:\n");
printf("addr, size 0x%jx, 0x%jx\n", efifb.fb_addr, printf("addr, size 0x%jx, 0x%jx\n", efifb.fb_addr,
efifb.fb_size); efifb.fb_size);
printf("dimensions %d x %d\n", efifb.fb_width, printf("dimensions %d x %d\n", efifb.fb_width,
efifb.fb_height); efifb.fb_height);
printf("stride %d\n", efifb.fb_stride); printf("stride %d\n", efifb.fb_stride);
printf("masks 0x%08x, 0x%08x, 0x%08x, 0x%08x\n", printf("masks 0x%08x, 0x%08x, 0x%08x, 0x%08x\n",
efifb.fb_mask_red, efifb.fb_mask_green, efifb.fb_mask_blue, efifb.fb_mask_red, efifb.fb_mask_green, efifb.fb_mask_blue,
▲ Show 20 Lines • Show All 221 Lines • Show Last 20 Lines