Changeset View
Standalone View
misc/lxi-tools/Makefile
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
# $FreeBSD$ | |||||
PORTNAME= lxi-tools | |||||
DISTVERSIONPREFIX= v | |||||
DISTVERSION= 1.16 | |||||
CATEGORIES= misc | |||||
MAINTAINER= dg@syrec.org | |||||
COMMENT= Collection of tools that enables control of LXI compatible instruments | |||||
LICENSE= BSD3CLAUSE | |||||
LICENSE_FILE= ${WRKSRC}/COPYING | |||||
LIB_DEPENDS= liblxi.so:misc/liblxi | |||||
USES= autoreconf localbase readline | |||||
USE_GITHUB= yes | |||||
GNU_CONFIGURE= yes | |||||
CONFIGURE_ARGS= --with-bash-completion-dir=${PREFIX}/etc/bash_completion.d | |||||
mat: Not needed. | |||||
CFLAGS+= -D_WITH_GETLINE # enable getline(3) prototype | |||||
PORTDOCS= README | |||||
PLIST_FILES= bin/lxi \ | |||||
man/man1/lxi.1.gz \ | |||||
${PREFIX}/etc/bash_completion.d/lxi | |||||
OPTIONS_DEFINE= DOCS | |||||
Done Inline ActionsAny reason not to enable BASH by default ? mat: Any reason not to enable BASH by default ? | |||||
Done Inline ActionsFor consistency with other shells (in other ports) and with bash in other ports. And this is real cheap. :-) yuri: For consistency with other shells (in other ports) and with bash in other ports. And this is… | |||||
Done Inline ActionsConsistency is a nice thing, but in this case, most of those ports are wrong, and not installing a 500 bytes file because someone may not needed is not how default options are supposed to work. mat: Consistency is a nice thing, but in this case, most of those ports are wrong, and not… | |||||
Done Inline ActionsAdam Weinberger also expressed preference to allow user decide such things, no matter how small. yuri: Adam Weinberger also expressed preference to allow user decide such things, no matter how small. | |||||
Done Inline ActionsI never said to remove the option. Advanced users using the ports tree or building their own packages can decide what they want. I said that some users will need the completion file, and this is reason enough to enable the option by default. mat: I never said to remove the option. Advanced users using the ports tree or building their own… | |||||
Done Inline ActionsShouldn't such things be enabled on the framework level? Just like DOCS is enabled by default, you can make BASH enabled by default too, and remove OPTIONS_DEFAULT=BASH from all ports. yuri: Shouldn't such things be enabled on the framework level? Just like `DOCS` is enabled by default… | |||||
Done Inline ActionsHi Mat, BASH option default here was based on merit. This software has small command/options set and doesn't need any completions (IMO). This particular bash completion doesn't do much, I included it in the port only because it is in the upstream package. dmgk: Hi Mat,
BASH option default here was based on merit. This software has small command/options… | |||||
Done Inline ActionsNot for shell completion files, I haven't. Ports should ALWAYS install their shell completion files. You change shells, enable completions, and suddenly all the ports you've installed have completions. Don't make it an option. Always install it. It simply makes for a much better user experience. adamw: Not for shell completion files, I haven't.
Ports should ALWAYS install their shell completion… | |||||
Done Inline Actions
Then, IMO, they should all be made default in the framework. -) yuri: > Ports should ALWAYS install their shell completion files.
Then, IMO, they should all be made… | |||||
Not Done Inline ActionsNo. They shouldn't be options in the first place. Just install them. adamw: No. They shouldn't be options in the first place. Just install them. | |||||
post-install-DOCS-on: | |||||
@${MKDIR} ${STAGEDIR}${DOCSDIR} | |||||
${INSTALL_MAN} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR} | |||||
.include <bsd.port.mk> |
Not needed.