Changeset View
Changeset View
Standalone View
Standalone View
Mk/bsd.sanity.mk
# $FreeBSD$ | # $FreeBSD$ | ||||
# | # | ||||
# MAINTAINER: portmgr@FreeBSD.org | # MAINTAINER: portmgr@FreeBSD.org | ||||
# | # | ||||
.if defined(WITHOUT_NLS) | .if defined(WITHOUT_NLS) | ||||
WARNING+= "WITHOUT_NLS is deprecated use OPTIONS_UNSET=NLS instead" | WARNING+= "WITHOUT_NLS is unsupported use OPTIONS_UNSET=NLS instead" | ||||
.endif | .endif | ||||
eadler: eh, I'd just remove this. years of warnings is enough | |||||
Done Inline ActionsI disagree we should say it is unsupported and even maybe replace the WARNING with an ERROR imho. Poisonning variables that used to be documented and used for a while is very important. Lots of old documentation are still available online, on random blogs etc. bapt: I disagree we should say it is unsupported and even maybe replace the WARNING with an ERROR… | |||||
Done Inline ActionsI was considering adding an ERROR variable, maybe I will, to make sure people update their systems. mat: I was considering adding an ERROR variable, maybe I will, to make sure people update their… | |||||
Done Inline Actions@eadler: Join ports@ and answer the same question over and over again and you'll see why error conditions need to be spelled out explicitly :-) adamw: @eadler: Join ports@ and answer the same question over and over again and you'll see why error… | |||||
.if defined(NOPORTDOCS) | |||||
WARNING+= "NOPORTDOCS is unsupported use OPTIONS_UNSET=DOCS instead" | |||||
.endif | |||||
.if defined(NOPORTEXAMPLES) | |||||
WARNING+= "NOPORTEXAMPLES is unsupported use OPTIONS_UNSET=EXAMPLES instead" | |||||
.endif | |||||
.for opt in ${ALL_OPTIONS:NDEBUG} | |||||
.if defined(WITH_${opt}) | |||||
WARNING+= "WITH_${opt} is unsupported, use WITH=${opt} on the command line, or one of these in /etc/make.conf, OPTIONS_SET+=${opt} to set it globally, or ${OPTIONS_NAME}_SET+=${opt} for only this port." | |||||
.endif | |||||
.if defined(WITHOUT_${opt}) | |||||
WARNING+= "WITHOUT_${opt} is unsupported, use WITHOUT=${opt} on the command line, or one of these in /etc/make.conf, OPTIONS_UNSET+=${opt} to set it globally, or ${OPTIONS_NAME}_UNSET+=${opt} for only this port." | |||||
.endif | |||||
.endfor | |||||
.if defined(WITH_NEW_XORG) || defined(WITHOUT_NEW_XORG) | .if defined(WITH_NEW_XORG) || defined(WITHOUT_NEW_XORG) | ||||
WARNING+= "WITH_NEW_XORG and WITHOUT_NEW_XORG knobs were removed and have no effect" | WARNING+= "WITH_NEW_XORG and WITHOUT_NEW_XORG knobs were removed and have no effect" | ||||
.endif | .endif | ||||
.if defined(WITH_KMS) || defined(WITHOUT_KMS) | .if defined(WITH_KMS) || defined(WITHOUT_KMS) | ||||
WARNING+= "WITH_KMS was removed and has no effect" | WARNING+= "WITH_KMS was removed and has no effect" | ||||
.endif | .endif | ||||
▲ Show 20 Lines • Show All 241 Lines • Show Last 20 Lines |
eh, I'd just remove this. years of warnings is enough