Page MenuHomeFreeBSD
Differential D13227 Diff 36050 www/py-unit-python/Makefile

Changeset View

Standalone View

View Options

www/py-unit-python/Makefile

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# Created by: Li-Wen Hsu <lwhsu@FreeBSD.org>
# $FreeBSD$
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
PKGNAMESUFFIX= -python
matUnsubmitted
Not Done
Inline Actions

Side question, does it really need the PKGNAMESUFFIX ?

I mean, it already going to be named pyXY-unit, unless there is another port that generates those packages, I think the -python bit should be dropped.

mat: Side question, does it really need the PKGNAMESUFFIX ? I mean, it already going to be named…
lwhsuAuthorUnsubmitted
Not Done
Inline Actions

I'd like to keep consistency between unit modules, unit-go, unit-php and unit-python.
How about moving to suffix like: unit-python-py24 or even unit-py24?

lwhsu: I'd like to keep consistency between unit modules, unit-go, unit-php and unit-python. How about…
matUnsubmitted
Not Done
Inline Actions

well, pyXY-unit already says python, no need to repeat it.

mat: well, pyXY-unit already says python, no need to repeat it.
lwhsuAuthorUnsubmitted
Not Done
Inline Actions

I thought is pyXX- is the flavor and unit-python is the port name. I prefer this form, honestly.
If you insist on removing -python suffix, I will do so.

The name I wanted most is unit-pythonXX, though it is not consistent with other ports in the tree.

lwhsu: I thought is `pyXX-` is the flavor and `unit-python` is the port name. I prefer this form…
matUnsubmitted
Not Done
Inline Actions

Here, in the end, with what is currently in the review, we have:

PORTNAME=    unit
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
PKGNAMESUFFIX= -python

So the package names will end up being py27-unit-python and py36-unit-python. If you really want to repeat the fact that it is python, then do so, but I find it strange as it is purely artificial and superfluous.

mat: Here, in the end, with what is currently in the review, we have: ``` PORTNAME= unit…
COMMENT= Python module for NGINX Unit
matUnsubmitted
Done
Inline Actions

Remove ${PYTHON_VER} it is obvious by the pyXY- prefix.

mat: Remove ${PYTHON_VER} it is obvious by the pyXY- prefix.
lwhsuAuthorUnsubmitted
Done
Inline Actions

OK, though I thought it's no harm to mention again :)

lwhsu: OK, though I thought it's no harm to mention again :)
USES= python gettext-runtime
USE_PYTHON= flavors
matUnsubmitted
Done
Inline Actions

s/?=/=/

mat: s/?=/=/
matUnsubmitted
Not Done
Inline Actions

Unless there are other ports actually using the non default Python versions, I don't think allflavors is needed here.

mat: Unless there are other ports actually using the non default Python versions, I don't think…
lwhsuAuthorUnsubmitted
Not Done
Inline Actions

I originally did this, but @osa (www/unit maintainer) would like to keep the old behavior of building all python modules for unit.

lwhsu: I originally did this, but @osa (www/unit maintainer) would like to keep the old behavior of…
matUnsubmitted
Not Done
Inline Actions

There is no such behavior. With the current code it only builds the first selected version.

mat: There is no such behavior. With the current code it only builds the first selected version.
lwhsuAuthorUnsubmitted
Not Done
Inline Actions

Oh, right, what I remembered is wrong. Just keeping the ability to build modules for other python versions is fine.

lwhsu: Oh, right, what I remembered is wrong. Just keeping the ability to build modules for other…
PLIST_FILES= libexec/unit/modules/python${PYTHON_SUFFIX}.unit.so
matUnsubmitted
Not Done
Inline Actions
PLIST_FILES= libexec/unit/modules/python${PYTHON_SUFFIX}.unit.so
mat: ``` PLIST_FILES= libexec/unit/modules/python${PYTHON_SUFFIX}.unit.so ```
lwhsuAuthorUnsubmitted
Not Done
Inline Actions

I checked other PLIST_FILES usage in the ports tree, we use %% for PLIST_SUB. Did I miss anything?

lwhsu: I checked other `PLIST_FILES` usage in the ports tree, we use `%%` for `PLIST_SUB`. Did I miss…
matUnsubmitted
Not Done
Inline Actions

Just because a few other did a bad thing does not mean you have to repeat it.
The %%FOO%% placeholders are for the pkg-plist file, because it is a static file and variables need to be carried there.
Here, in the Makefile, you can access the variable directly, use it.

mat: Just because a few other did a bad thing does not mean you have to repeat it. The %%FOO%%…
USE_RC_SUBR?= # reset to empty
MASTERDIR= ${.CURDIR}/../unit
post-configure:
cd ${CONFIGURE_WRKSRC} && \
./configure python --module=python${PYTHON_SUFFIX} \
--config=${PYTHON_CMD}-config
do-install:
${MKDIR} ${STAGEDIR}${PREFIX}/libexec/unit/modules/
${INSTALL_LIB} ${WRKSRC}/build/python${PYTHON_SUFFIX}.unit.so \
${STAGEDIR}${PREFIX}/libexec/unit/modules/
.include "${MASTERDIR}/Makefile"