Changeset View
Standalone View
www/py-unit-python/Makefile
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
# Created by: Li-Wen Hsu <lwhsu@FreeBSD.org> | |||||
# $FreeBSD$ | |||||
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | |||||
PKGNAMESUFFIX= -python | |||||
mat: Side question, does it really need the PKGNAMESUFFIX ?
I mean, it already going to be named… | |||||
Not Done Inline ActionsI'd like to keep consistency between unit modules, unit-go, unit-php and unit-python. lwhsu: I'd like to keep consistency between unit modules, unit-go, unit-php and unit-python.
How about… | |||||
Not Done Inline Actionswell, pyXY-unit already says python, no need to repeat it. mat: well, pyXY-unit already says python, no need to repeat it. | |||||
Not Done Inline ActionsI thought is pyXX- is the flavor and unit-python is the port name. I prefer this form, honestly. The name I wanted most is unit-pythonXX, though it is not consistent with other ports in the tree. lwhsu: I thought is `pyXX-` is the flavor and `unit-python` is the port name. I prefer this form… | |||||
Not Done Inline ActionsHere, in the end, with what is currently in the review, we have: PORTNAME= unit PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMESUFFIX= -python So the package names will end up being py27-unit-python and py36-unit-python. If you really want to repeat the fact that it is python, then do so, but I find it strange as it is purely artificial and superfluous. mat: Here, in the end, with what is currently in the review, we have:
```
PORTNAME= unit… | |||||
COMMENT= Python ${PYTHON_VER} module for NGINX Unit | |||||
Done Inline ActionsRemove ${PYTHON_VER} it is obvious by the pyXY- prefix. mat: Remove ${PYTHON_VER} it is obvious by the pyXY- prefix. | |||||
Done Inline ActionsOK, though I thought it's no harm to mention again :) lwhsu: OK, though I thought it's no harm to mention again :) | |||||
USES?= python gettext-runtime | |||||
Done Inline Actionss/?=/=/ mat: s/?=/=/ | |||||
PLIST_FILES= libexec/unit/modules/python%%PYTHON_SUFFIX%%.unit.so | |||||
Not Done Inline ActionsUnless there are other ports actually using the non default Python versions, I don't think allflavors is needed here. mat: Unless there are other ports actually using the non default Python versions, I don't think… | |||||
Not Done Inline ActionsI originally did this, but @osa (www/unit maintainer) would like to keep the old behavior of building all python modules for unit. lwhsu: I originally did this, but @osa (www/unit maintainer) would like to keep the old behavior of… | |||||
Not Done Inline ActionsThere is no such behavior. With the current code it only builds the first selected version. mat: There is no such behavior. With the current code it only builds the first selected version. | |||||
Not Done Inline ActionsOh, right, what I remembered is wrong. Just keeping the ability to build modules for other python versions is fine. lwhsu: Oh, right, what I remembered is wrong. Just keeping the ability to build modules for other… | |||||
USE_RC_SUBR?= # reset to empty | |||||
Not Done Inline ActionsPLIST_FILES= libexec/unit/modules/python${PYTHON_SUFFIX}.unit.so mat: ```
PLIST_FILES= libexec/unit/modules/python${PYTHON_SUFFIX}.unit.so
``` | |||||
Not Done Inline ActionsI checked other PLIST_FILES usage in the ports tree, we use %% for PLIST_SUB. Did I miss anything? lwhsu: I checked other `PLIST_FILES` usage in the ports tree, we use `%%` for `PLIST_SUB`. Did I miss… | |||||
Not Done Inline ActionsJust because a few other did a bad thing does not mean you have to repeat it. mat: Just because a few other did a bad thing does not mean you have to repeat it.
The %%FOO%%… | |||||
MASTERDIR= ${.CURDIR}/../unit | |||||
post-configure: | |||||
cd ${CONFIGURE_WRKSRC} && \ | |||||
./configure python --module=python${PYTHON_SUFFIX} \ | |||||
--config=${PYTHON_CMD}-config | |||||
do-install: | |||||
${MKDIR} ${STAGEDIR}${PREFIX}/libexec/unit/modules/ | |||||
${INSTALL_LIB} ${WRKSRC}/build/python${PYTHON_SUFFIX}.unit.so \ | |||||
${STAGEDIR}${PREFIX}/libexec/unit/modules/ | |||||
.include "${MASTERDIR}/Makefile" |
Side question, does it really need the PKGNAMESUFFIX ?
I mean, it already going to be named pyXY-unit, unless there is another port that generates those packages, I think the -python bit should be dropped.