Changeset View
Standalone View
x11-themes/xfce-evolution/Makefile
- This file was added.
Property | Old Value | New Value |
---|---|---|
svn:eol-style | null | native \ No newline at end of property |
svn:keywords | null | FreeBSD=%H \ No newline at end of property |
svn:mime-type | null | text/plain \ No newline at end of property |
# $FreeBSD$ | |||||
PORTNAME= xfce-evolution | |||||
DISTVERSION= 3.1.6 | |||||
CATEGORIES= x11-themes | |||||
MASTER_SITES= SF/${PORTNAME} | |||||
tcbernerUnsubmitted Done Inline Actionstcberner: ^ is this a joke? ^^ | |||||
Done Inline ActionsNo, it reuses the THEME variable. yuri: No, it reuses the THEME variable.
Would you prefer to just type the text instead? | |||||
Done Inline Actionswell, the punchline is on line 3, isn't it? tcberner: well, the punchline is on line 3, isn't it? | |||||
Done Inline ActionsI am definitely laughing! Is the subdir likely to change? If not, it's probably safe to hardcode it. adamw: I am definitely laughing!
Is the subdir likely to change? If not, it's probably safe to… | |||||
MAINTAINER= fbsd@opal.com | |||||
Done Inline ActionsMASTER_SITES= SF/${THEME:tW:tl:S/ /-/g} Never use MASTER_SITE_SUBDIR. mat: ```
MASTER_SITES= SF/${THEME:tW:tl:S/ /-/g}
```
Never use MASTER_SITE_SUBDIR.
| |||||
Done Inline ActionsUpdated. yuri: Updated.
Should MASTER_SITE_SUBDIR be renamed into _MASTER_SITE_SUBDIR then in Mk/?
| |||||
COMMENT= Complete Xfce Evolution Gtk2, Gtk3, Qt4, Qt5, wxWidgets, Xfce themes | |||||
LICENSE= GPLv2 | |||||
LICENSE_FILE= ${WRKSRC}/COPYRIGHT | |||||
RUN_DEPENDS= gtk-murrine-engine>0:x11-themes/gtk-murrine-engine \ | |||||
qt5-style-plugins>0:x11-themes/qt5-style-plugins | |||||
USES= zip:infozip # infozip because unzip on 10 doesn't unpack symbolic links | |||||
Done Inline Actions^maybe it would be a bit more compact to use the pkgname to depend on it instead of these long paths :) tcberner: ^maybe it would be a bit more compact to use the pkgname to depend on it instead of these long… | |||||
Done Inline ActionsHow to do this? For example, RUN_DEPENDS=gtk-murrine-engine:x11-themes/gtk-murrine-engine doesn't work. yuri: How to do this?
For example, `RUN_DEPENDS=gtk-murrine-engine:x11-themes/gtk-murrine-engine`… | |||||
Done Inline Actions
I grant you it's nicer to depend on a file, but these paths just look too long and subject o change :D tcberner: [[https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-version… | |||||
Done Inline ActionsThis didn't occur to me fast enough. -) yuri: This didn't occur to me fast enough. -) | |||||
USE_GNOME= gtk20:build | |||||
NO_BUILD= yes | |||||
NO_ARCH= yes | |||||
EXTRACT_AFTER_ARGS= -d ${DISTNAME} | |||||
post-extract: | |||||
@cd ${WRKSRC} && \ | |||||
for d in "Xfce Evolution "*; do \ | |||||
${MV} "$$d" $$(${ECHO} $$d | ${SED} 's/ /-/g'); \ | |||||
done | |||||
do-install: | |||||
Done Inline Actions^ I think you could come up with something nicer here Which might look a bit cleaner. tcberner: ^ I think you could come up with something nicer here
a) is it really important to get rid of… | |||||
Done Inline ActionsI simplified it. -) yuri: I simplified it. -) | |||||
@${MKDIR} ${STAGEDIR}${PREFIX}/share/themes | |||||
@cd ${WRKSRC} && \ | |||||
${COPYTREE_SHARE} "Xfce-Evolution-*" ${STAGEDIR}${PREFIX}/share/themes; | |||||
@${REINPLACE_CMD} -i '' -e 's|^#!/bin/bash|#!/bin/sh|' ${STAGEDIR}${PREFIX}/share/themes/*/00.[0-4]0 | |||||
Done Inline Actions^out of curiousity. Have you checked whether they are really not requiring any bash features? tcberner: ^out of curiousity. Have you checked whether they are really not requiring any bash features? | |||||
Done Inline Actions-) Of course I did. They are all very simple and plain scripts. yuri: -) Of course I did. They are all very simple and plain scripts. | |||||
Done Inline Actionsvery good :) tcberner: very good :) | |||||
adamwUnsubmitted Done Inline ActionsJust FYI, if you wanted to, you could also use shebangfix here, which is very precise about how it modifies files. USES=shebangfix SHEBANG_REGEX= 00.[0-4]0 bash_CMD=/bin/sh adamw: Just FYI, if you wanted to, you could also use shebangfix here, which is very precise about how… | |||||
.include <bsd.port.mk> |