Page MenuHomeFreeBSD
Differential D12597 Diff 33727 www/libresonic-standalone/Makefile

Changeset View

Standalone View

View Options

www/libresonic-standalone/Makefile

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# Created by: Jeremie Le Hen <jlh@FreeBSD.org>
# $FreeBSD$
PORTNAME= libresonic-standalone
PORTVERSION= 6.2
CATEGORIES= www java
matUnsubmitted
Done
Inline Actions

missing tab after =

mat: missing tab after =
MASTER_SITES= https://github.com/Libresonic/libresonic/releases/download/v${PORTVERSION}/
DISTNAME= libresonic-v${PORTVERSION}
EXTRACT_SUFX= .war
# We don't want to extract the .war file, just copy it.
matUnsubmitted
Done
Inline Actions
PORTNAME=        libresonic
DISTVERSIONPREFIX=  v
DISTVERSION=        6.2
CATEGORIES=        www java
​MASTER_SITES=        https://github.com/Libresonic/libresonic/releases/download/v${DISTVERSION}/
PKGNAMESUFFIX=       -standalone
​EXTRACT_SUFX=        .war
mat: ``` PORTNAME= libresonic DISTVERSIONPREFIX= v DISTVERSION= 6.2 CATEGORIES=…
jlhAuthorUnsubmitted
Done
Inline Actions

Thanks :-). I wanted to stick to what there's in www/madsonic-standalone actually.

jlh: Thanks :-). I wanted to stick to what there's in www/madsonic-standalone actually.
EXTRACT_CMD= ${CP}
EXTRACT_BEFORE_ARGS=
matUnsubmitted
Done
Inline Actions

missing empty line before.

mat: missing empty line before.
EXTRACT_AFTER_ARGS= libresonic.war
matUnsubmitted
Done
Inline Actions

This should happen way way later.

mat: This should happen way way later.
jlhAuthorUnsubmitted
Done
Inline Actions

Move it below options.

jlh: Move it below options.
matUnsubmitted
Done
Inline Actions

Missing empty line before.

mat: Missing empty line before.
MAINTAINER= jlh@FreeBSD.org
COMMENT= Subsonic streaming media server, standalone version
LICENSE= GPLv3
OPTIONS_GROUP= TRANSCODING
TRANSCODING_DESC= Transcoding support
OPTIONS_GROUP_TRANSCODING= FFMPEG FLAC LAME VORBIS FAAC FAAD XMP MPC APE
FFMPEG_DESC= Depend on FFmpeg for audio and video transcoding
FLAC_DESC= Depend on FLAC for transcoding
LAME_DESC= Depend on LAME for MP3 transcoding
VORBIS_DESC= Depend on oggenc/oggdec for Vorbis transcoding
FAAC_DESC= Depend on FAAD for AAC/M4A transcoding
FAAD_DESC= Depend on FAAC for AAC/M4A transcoding
XMP_DESC= Depend on XMP for module file transcoding
MPC_DESC= Depend on mpcdec for MPC transcoding
APE_DESC= Depend on mac for Monkey's Audio transcoding #'
matUnsubmitted
Done
Inline Actions

Out of order.

mat: Out of order.
OPTIONS_DEFAULT= FFMPEG
OPTIONS_SUB= yes
FFMPEG_RUN_DEPENDS= ffmpeg:multimedia/ffmpeg
FLAC_RUN_DEPENDS= flac:audio/flac
LAME_RUN_DEPENDS= lame:audio/lame
VORBIS_RUN_DEPENDS= oggenc:audio/vorbis-tools
FAAC_RUN_DEPENDS= faac:audio/faac
FAAD_RUN_DEPENDS= faad:audio/faad
XMP_RUN_DEPENDS= xmp:audio/xmp
MPC_RUN_DEPENDS= mpcdec:audio/musepack
APE_RUN_DEPENDS= mac:audio/mac
.include <bsd.port.options.mk>
matUnsubmitted
Done
Inline Actions

Not needed.

mat: Not needed.
NO_WRKSUBDIR= yes
NO_BUILD= yes
USE_JAVA= yes
USE_RC_SUBR= libresonic
JAVA_VERSION= 1.8+
matUnsubmitted
Done
Inline Actions

Happen too late.

mat: Happen too late.
jlhAuthorUnsubmitted
Done
Inline Actions

I lifted up next to the first block. I don't know where it's supposed to go. Why is it important, BTW?

jlh: I lifted up next to the first block. I don't know where it's supposed to go. Why is it…
matUnsubmitted
Done
Inline Actions

To make it easier for anyone to work on any port, there is a standardized way to write things in a Makefile: Chapter 14. Order of Variables in Port Makefiles.

mat: To make it easier for anyone to work on any port, there is a standardized way to write things…
JAVA_RUN= yes
# Don't waste UID/GID and reuse Subsonic's user.
USERS= subsonic
GROUPS= subsonic
LIBRESONIC_HOME=/var/libresonic
PLIST_SUB+= LIBRESONIC_HOME="${LIBRESONIC_HOME}" \
USER="${USERS}" \
matUnsubmitted
Done
Inline Actions

Why += ?

mat: Why += ?
matUnsubmitted
Done
Inline Actions

missing tab after =

mat: missing tab after =
GROUP="${GROUPS}"
SUB_FILES= pkg-message \
message-transcoding
SUB_LIST= LIBRESONIC_HOME="${LIBRESONIC_HOME}" \
USER="${USERS}" \
GROUP="${GROUPS}" \
JAVA="${JAVA}"
do-install:
@${CAT} ${PKGDIR}/pkg-message-spacer >> ${PKGMESSAGE}
@${CAT} ${WRKDIR}/message-transcoding >> ${PKGMESSAGE}
@${CAT} ${PKGDIR}/pkg-message-spacer >> ${PKGMESSAGE}
${MKDIR} ${STAGEDIR}${DATADIR}
${INSTALL_DATA} ${WRKSRC}/libresonic.war ${STAGEDIR}${DATADIR}/
matUnsubmitted
Done
Inline Actions

When using a do-install target, don't use a post-install one, put everything in do-install.

mat: When using a do-install target, don't use a post-install one, put everything in do-install.
post-install:
${MKDIR} ${STAGEDIR}${LIBRESONIC_HOME}/transcode
post-install-FFMPEG-on:
${LN} -sf ${PREFIX}/bin/ffmpeg ${STAGEDIR}${LIBRESONIC_HOME}/transcode/ffmpeg
post-install-FLAC-on:
${LN} -sf ${PREFIX}/bin/flac ${STAGEDIR}${LIBRESONIC_HOME}/transcode/flac
post-install-LAME-on:
${LN} -sf ${PREFIX}/bin/lame ${STAGEDIR}${LIBRESONIC_HOME}/transcode/lame
matUnsubmitted
Done
Inline Actions

Use ${RLN}

mat: [[ https://www.freebsd.org/doc/en/books/porters-handbook/special.html#staging-ex1 | Use ${RLN}…
.include <bsd.port.mk>