Changeset View
Changeset View
Standalone View
Standalone View
Mk/Uses/kde.mk
Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Lines | |||||
KTP_BRANCH?= stable | KTP_BRANCH?= stable | ||||
# ============================================================================== | # ============================================================================== | ||||
# === INSTALLATION PREFIX ====================================================== | # === INSTALLATION PREFIX ====================================================== | ||||
# Define installation prefix. | # Define installation prefix. | ||||
KDE_PREFIX= ${LOCALBASE} | KDE_PREFIX= ${LOCALBASE} | ||||
# ============================================================================== | # ============================================================================== | ||||
# === KDE_DIST HANDLING -- SETTING DEFAULT VALUES ============================== | |||||
. if defined(KDE_DIST) | |||||
KDE_DIST_PART=${KDE_DIST:C/\:.*//} | |||||
KDE_DIST_ARGS=${KDE_DIST:C/^[^\:]*(\:|\$)//:S/,/ /g} | |||||
mat: I don't think `:O:u` are needed here, the variable is literally defined on the previous line… | |||||
. if ${KDE_DIST_PART:Mapplications} | |||||
. if ${KDE_DIST_ARGS:Mlegacy} | |||||
PORTVERSION?= ${KDE4_APPLICATIONS_VERSION} | |||||
MASTER_SITES?= KDE/${KDE4_APPLICATIONS_BRANCH}/applications/${KDE4_APPLICATIONS_VERSION}/src | |||||
DIST_SUBDIR?= KDE/kde4/${KDE4_APPLICATIONS_VERSION} | |||||
. endif | |||||
. elif ${KDE_DIST_PART:Mkde4} | |||||
PORTVERSION?= ${KDE4_VERSION} | |||||
MASTER_SITES?= KDE/${KDE4_BRANCH}/${KDE4_VERSION}/src | |||||
DIST_SUBDIR?= KDE/kde4/${KDE4_VERSION} | |||||
. elif ${KDE_DIST_PART:Mkactivities} | |||||
PORTVERSION?= ${KDE4_ACTIVITIES_VERSION} | |||||
MASTER_SITES?= KDE/Attic/${KDE4_ACTIVITIES_VERSION}/src | |||||
DIST_SUBDIR?= KDE/kde4/${KDE4_ACTIVITIES_VERSION} | |||||
. elif ${KDE_DIST_PART:Mcalligra} | |||||
Done Inline ActionsIs this comment still relevant? I don't see anything Calligra-specific below. rakuco: Is this comment still relevant? I don't see anything Calligra-specific below. | |||||
PORTVERSION?= ${CALLIGRA_VERSION} | |||||
. if ${KDE_DIST_ARGS:Ml10n} | |||||
MASTER_SITES?= KDE/${CALLIGRA_BRANCH}/calligra-${PORTVERSION}/calligra-l10n | |||||
DIST_SUBDIR?= KDE/calligra/${PORTVERSION}/l10n | |||||
. else | |||||
MASTER_SITES?= KDE/${CALLIGRA_BRANCH}/calligra-${PORTVERSION} | |||||
DIST_SUBDIR?= KDE/calligra/${PORTVERSION} | |||||
. endif | |||||
. else | |||||
IGNORE?= unknown KDE_DIST_PART:KDE_DIST_ARGS value '${KDE_DIST_PART}':'${KDE_DIST_ARGS}' from '${KDE_DIST}' | |||||
. endif | |||||
. endif #defined(KDE_DIST) | |||||
# ============================================================================== | |||||
# ==== SETUP CMAKE ENVIRONMENT ================================================= | # ==== SETUP CMAKE ENVIRONMENT ================================================= | ||||
# Help cmake to find files when testing ports with non-default PREFIX. | # Help cmake to find files when testing ports with non-default PREFIX. | ||||
CMAKE_ARGS+= -DCMAKE_PREFIX_PATH="${LOCALBASE}" | CMAKE_ARGS+= -DCMAKE_PREFIX_PATH="${LOCALBASE}" | ||||
. if ${_KDE_VERSION:M*4*} | . if ${_KDE_VERSION:M*4*} | ||||
CMAKE_ARGS+= -DKDE4_BUILD_TESTS:BOOL=OFF | CMAKE_ARGS+= -DKDE4_BUILD_TESTS:BOOL=OFF | ||||
. endif | . endif | ||||
▲ Show 20 Lines • Show All 214 Lines • Show Last 20 Lines |
I don't think :O:u are needed here, the variable is literally defined on the previous line and can be kept clean. If it needs to be sorted, maybe just add a comment about it, as the unique thing, well, eyes should be enough to figure that out before committing a change 😄