Page MenuHomeFreeBSD
Differential D6781 Diff 17460 sys/boot/efi/libefi/efi_console.c

Changeset View

Standalone View

View Options

sys/boot/efi/libefi/efi_console.c

Context not available.
/* Try to read a key stroke. We wait for one if none is pending. */ /* Try to read a key stroke. We wait for one if none is pending. */
status = conin->ReadKeyStroke(conin, &key); status = conin->ReadKeyStroke(conin, &key);
if (status == EFI_NOT_READY) { while (status == EFI_NOT_READY) {
BS->WaitForEvent(1, &conin->WaitForKey, &junk); if (conin->WaitForKey != NULL)
impUnsubmitted
Not Done
Inline Actions

This check should be against zero since this isn't a bool or even a pointer.

imp: This check should be against zero since this isn't a bool or even a pointer.
manuAuthorUnsubmitted
Not Done
Inline Actions

From sys/boot/efi/include/efidef.h :
typedef VOID *EFI_EVENT;

So I should check against NULL.

manu: From sys/boot/efi/include/efidef.h : typedef VOID *EFI_EVENT; So I should check…
BS->WaitForEvent(1, &conin->WaitForKey, &junk);
status = conin->ReadKeyStroke(conin, &key); status = conin->ReadKeyStroke(conin, &key);
} }
switch (key.ScanCode) { switch (key.ScanCode) {
Context not available.