Page MenuHomeFreeBSD
Differential D40119 Diff 122051 emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh

Changeset View

Standalone View

View Options

emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh

Context not available.
+# hope that it will be useful, but WITHOUT ANY WARRANTY of any kind. +# hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
+# +#
+ +
+PATH="/usr/bin:/bin:/usr/sbin:/sbin" +PATH="/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin"
adamwUnsubmitted
Done
Inline Actions

I'm not sure that putting /usr/local/ before base is good practice. With this patch, a malicious /usr/local/bin/mount could be called instead of /sbin/mount. Would we be better off putting /usr/local/... at the end instead?

adamw: I'm not sure that putting `/usr/local/` before base is good practice. With this patch, a…
vvdAuthorUnsubmitted
Done
Inline Actions

My 1st version before upload here was:
/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/local/sbin
But changed to current after read patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=237357&action=diff

vvd: My 1st version before upload here was: /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin…
adamwUnsubmitted
Done
Inline Actions

I always start with what FreeBSD itself uses (from /etc/login.conf, and I skip ~/bin of course):

$ awk '/path/ {print;exit;}' /etc/login.conf
        :path=/sbin /bin /usr/sbin /usr/bin /usr/local/sbin /usr/local/bin ~/bin:\

At the end of the day, you're the committer. Don't be afraid to modify patches from submitters; they're counting on you for that. Most submitters see changes in the final patch as a learning opportunity.

adamw: I always start with what FreeBSD itself uses (from `/etc/login.conf`, and I skip `~/bin` of…
+CONFIG="/usr/local/etc/vbox/vbox.cfg" +CONFIG="/usr/local/etc/vbox/vbox.cfg"
arrowdUnsubmitted
Not Done
Inline Actions

Here %%PREFIX should be used, I believe.

arrowd: Here `%%PREFIX` should be used, I believe.
+ +
+test -r "${CONFIG}" && +test -r "${CONFIG}" &&
Context not available.