Page MenuHomeFreeBSD
Differential D27959 Diff 117716 usr.sbin/kldxref/kldxref.c

Changeset View

Standalone View

View Options

usr.sbin/kldxref/kldxref.c

Context not available.
{ {
FTS *ftsp; FTS *ftsp;
FTSENT *p; FTSENT *p;
char *dot = NULL;
int opt, fts_options, ival; int opt, fts_options, ival;
struct stat sb; struct stat sb;
Context not available.
fwrite(&ival, sizeof(ival), 1, fxref); fwrite(&ival, sizeof(ival), 1, fxref);
reccnt = 0; reccnt = 0;
} }
/* skip non-files and separate debug files */ /* skip non-files.. */
if (p->fts_info != FTS_F) if (p->fts_info != FTS_F)
continue; continue;
if (p->fts_namelen >= 6 && /* and separate .debug, .symbol and .pkgsave files */
kevansUnsubmitted
Done
Inline Actions

I think we can safely drop .symbols from this list, @emaste transitioned to .debug in 05117b57a54a -- surely enough time has passed that we can stop explicitly caring about or referencing them, hopefully...

kevans: I think we can safely drop .symbols from this list, @emaste transitioned to .debug in…
strcmp(p->fts_name + p->fts_namelen - 6, ".debug") == 0) /* by skipping all files with 2 dots */
impUnsubmitted
Not Done
Inline Actions

This should be

/*
 * Skip files that generate errors like .debug, .symbol and .pkgsave
 * by generally skipping all files with two dots.
 */

since it's a multi-line comment.

imp: This should be ``` /* * Skip files that generate errors like .debug, .symbol and .pkgsave *…
continue; dot = strchr(p->fts_name, '.');
if (p->fts_namelen >= 8 && if (dot && strchr(dot + 1, '.') != NULL)
strcmp(p->fts_name + p->fts_namelen - 8, ".symbols") == 0)
continue; continue;
read_kld(p->fts_path, p->fts_name); read_kld(p->fts_path, p->fts_name);
} }
Context not available.