No One
Actions

Authored By

	hiren
	Aug 4 2015, 9:08 PM

Size

2 KB

Referenced Files

None

Subscribers

None

View Options


	--pWOmaDnDlrCGjNh4
	Content-Type: text/plain; charset=us-ascii
	Content-Disposition: inline
	Content-Transfer-Encoding: quoted-printable

	!accept Thanks for the manpage update.

	On 08/04/15 at 09:01P, sbruno (Sean Bruno) wrote:
	> sbruno updated this revision to Diff 7657.
	> sbruno added a comment.
	> This revision now requires review to proceed.
	> Herald added a reviewer: manpages.
	>=20
	> Add manpage update for new tuneable, disable_crc_stripping.
	>=20
	>=20
	> REPOSITORY
	> rS FreeBSD src repository
	>=20
	> CHANGES SINCE LAST UPDATE
	> https://reviews.freebsd.org/D3282?vs=3D7615&id=3D7657
	>=20
	> BRANCH
	> /head
	>=20
	> REVISION DETAIL
	> https://reviews.freebsd.org/D3282
	>=20
	> AFFECTED FILES
	> share/man/man4/em.4
	> sys/dev/e1000/if_em.c
	>
	[skip]
	> diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c
	> --- a/sys/dev/e1000/if_em.c
	> +++ b/sys/dev/e1000/if_em.c
	> @@ -366,6 +366,10 @@
	> =20
	> static SYSCTL_NODE(_hw, OID_AUTO, em, CTLFLAG_RD, 0, "EM driver paramete=
	rs");
	> =20
	> +static int em_disable_crc_stripping =3D 0;
	> +SYSCTL_INT(_hw_em, OID_AUTO, disable_crc_stripping, CTLFLAG_RD,
	> + &em_disable_crc_stripping, 0, "Disable CRC Stripping");
	> +
	> static int em_tx_int_delay_dflt =3D EM_TICKS_TO_USECS(EM_TIDV);
	> static int em_rx_int_delay_dflt =3D EM_TICKS_TO_USECS(EM_RDTR);
	> SYSCTL_INT(_hw_em, OID_AUTO, tx_int_delay, CTLFLAG_RDTUN, &em_tx_int_del=
	ay_dflt,
	> @@ -4514,7 +4518,8 @@
	> (hw->mac.mc_filter_type << E1000_RCTL_MO_SHIFT);
	> =20
	> /* Strip the CRC */
	> - rctl \|=3D E1000_RCTL_SECRC;
	> + if (!em_disable_crc_stripping)
	> + rctl \|=3D E1000_RCTL_SECRC;
	> =20
	> /* Make sure VLAN Filters are off */
	> rctl &=3D ~E1000_RCTL_VFE;
	> diff --git a/share/man/man4/em.4 b/share/man/man4/em.4
	> --- a/share/man/man4/em.4
	> +++ b/share/man/man4/em.4
	> @@ -205,6 +205,10 @@
	> prompt before booting the kernel or stored in
	> .Xr loader.conf 5 .
	> .Bl -tag -width indent
	> +.It Va hw.em.disable_crc_stripping
	> +Disable or enable hardware stripping of CRC field. Most often used
	> +on BMC/IPMI shared interfaces.
	I'd just say "Disable hardw...." but I see you are following the suite.=20
	> +Default 0 (enabled)
	> .It Va hw.em.eee_setting
	> Disable or enable Energy Efficient Ethernet.
	> Default 1 (disabled).
	>=20


	--pWOmaDnDlrCGjNh4
	Content-Type: application/pgp-signature

	-----BEGIN PGP SIGNATURE-----
	Version: GnuPG v2.0.22 (FreeBSD)

	iQF8BAEBCgBmBQJVwSnUXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
	ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4
	QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lQysH/jU8BVkQ+BkbhUhkGbb6xLur
	KKcp9k9uCeF6zPqPDEQ+3zMBYeYigvLd0lg6MWFvT3CtQ9hvYgw5PLjfZKO+z/Pq
	+rdrS+XJgNQRQndEF94oW9AW2YM6tsc1RUWPVq57OABgOeA/p7mkYJf/NXvQAL9F
	O2/RkOvgACs5KukctTE1Ou2g7esRPG2mMad+D9hw1e9bNJRVjRBw70txoojkHu3t
	5JfMvul021V9I0mYLGTfA4PFs5jLGrnumoWc/W/3NgISAztMuXCJA0nCmHMqNp6K
	cxgHY4K+aS91rvNrY+OeE2OapP0fmTGy0+OrG++Ltdm95Hr01Vg5XlneA2k5coo=
	=/jAs
	-----END PGP SIGNATURE-----

	--pWOmaDnDlrCGjNh4--

File Metadata

Mime Type: text/plain
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 191073
Default Alt Text: (2 KB)

Event Timeline