Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F177853384
D60914.1795434399.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Authored By
Unknown
Size
1 KB
Referenced Files
None
Subscribers
None
D60914.1795434399.diff
View Options
diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c
--- a/sys/dev/iicbus/iichid.c
+++ b/sys/dev/iicbus/iichid.c
@@ -180,6 +180,7 @@
int sampling_rate_slow; /* iicbus lock */
int sampling_rate_fast;
int sampling_hysteresis;
+ sbintime_t next_sample; /* iicbus lock */
int missing_samples; /* iicbus lock */
int dup_samples; /* iicbus lock */
iichid_size_t dup_size; /* iicbus lock */
@@ -527,6 +528,7 @@
{
struct iichid_softc *sc;
device_t parent;
+ sbintime_t now, period;
iichid_size_t actual;
bool bus_requested;
int error, rate;
@@ -569,8 +571,21 @@
rate = sc->sampling_rate_slow;
else
rate = sc->sampling_rate_fast;
+ period = SBT_1S / MAX(rate, 1);
+ /*
+ * Schedule against an absolute deadline advanced by one
+ * period per sample, so that neither the time spent in the
+ * I2C transaction and handler dispatch nor the taskqueue
+ * wakeup latency stretches the sampling period. If the
+ * deadline has already passed then only advance the sample
+ * by one period rather than bursting polls to catch up.
+ */
+ now = sbinuptime();
+ sc->next_sample += period;
+ if (sc->next_sample <= now)
+ sc->next_sample = now + period;
taskqueue_enqueue_timeout_sbt(sc->taskqueue, &sc->sampling_task,
- SBT_1S / MAX(rate, 1), 0, C_PREL(2));
+ sc->next_sample, 0, C_ABSOLUTE);
}
out:
if (bus_requested)
@@ -746,6 +761,7 @@
sc->missing_samples = sc->sampling_hysteresis;
sc->dup_samples = 0;
sc->dup_size = 0;
+ sc->next_sample = sbinuptime();
taskqueue_enqueue_timeout(sc->taskqueue, &sc->sampling_task, 0);
return (0);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 23, 11:46 AM (14 h, 28 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
41177515
Default Alt Text
D60914.1795434399.diff (1 KB)
Attached To
Mode
D60914: iichid: keep a fixed sampling cadence in polled mode
Attached
Detach File
Event Timeline