Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F177641507
D57158.1794925632.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Authored By
Unknown
Size
809 B
Referenced Files
None
Subscribers
None
D57158.1794925632.diff
View Options
Index: sys/netlink/netlink_generic.c
===================================================================
--- sys/netlink/netlink_generic.c
+++ sys/netlink/netlink_generic.c
@@ -115,7 +115,7 @@
genl_handle_message(struct nlmsghdr *hdr, struct nl_pstate *npt)
{
struct nlpcb *nlp = npt->nlp;
- struct genl_family *gf;
+ struct genl_family *gf = NULL;
uint16_t family_id;
int error = 0;
@@ -127,9 +127,10 @@
}
family_id = hdr->nlmsg_type - GENL_MIN_ID;
- gf = &families[family_id];
- if (__predict_false(family_id >= MAX_FAMILIES ||
- gf->family_name == NULL)) {
+ if (family_id < MAX_FAMILIES)
+ gf = &families[family_id];
+
+ if (__predict_false(gf == NULL || gf->family_name == NULL)) {
NLP_LOG(LOG_DEBUG, nlp, "invalid message type: %d",
hdr->nlmsg_type);
return (ENOTSUP);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 17, 2:27 PM (12 h, 8 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
41801471
Default Alt Text
D57158.1794925632.diff (809 B)
Attached To
Mode
D57158: netlink: Avoid undefined behaviour
Attached
Detach File
Event Timeline