Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F177635718
D21416.1794908945.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Authored By
Unknown
Size
1 KB
Referenced Files
None
Subscribers
None
D21416.1794908945.diff
View Options
Index: sys/netinet/tcp_ratelimit.c
===================================================================
--- sys/netinet/tcp_ratelimit.c
+++ sys/netinet/tcp_ratelimit.c
@@ -390,12 +390,10 @@
rs->rs_ifp->if_xname,
CTLFLAG_RW, 0,
"");
- CK_LIST_INSERT_HEAD(&int_rs, rs, next);
- /* Unlock to allow the sysctl stuff to allocate */
- mtx_unlock(&rs_mtx);
rl_add_syctl_entries(rl_sysctl_root, rs);
- /* re-lock for our caller */
mtx_lock(&rs_mtx);
+ CK_LIST_INSERT_HEAD(&int_rs, rs, next);
+ mtx_unlock(&rs_mtx);
return (rs);
} else if ((rl.flags & RT_IS_INDIRECT) == RT_IS_INDIRECT) {
memset(rs, 0, sizeof(struct tcp_rate_set));
@@ -410,12 +408,10 @@
rs->rs_ifp->if_xname,
CTLFLAG_RW, 0,
"");
- CK_LIST_INSERT_HEAD(&int_rs, rs, next);
- /* Unlock to allow the sysctl stuff to allocate */
- mtx_unlock(&rs_mtx);
rl_add_syctl_entries(rl_sysctl_root, rs);
- /* re-lock for our caller */
mtx_lock(&rs_mtx);
+ CK_LIST_INSERT_HEAD(&int_rs, rs, next);
+ mtx_unlock(&rs_mtx);
return (rs);
} else if ((rl.flags & RT_IS_FIXED_TABLE) == RT_IS_FIXED_TABLE) {
/* Mellanox most likely */
@@ -560,7 +556,6 @@
goto bail;
}
rs_number_alive++;
- CK_LIST_INSERT_HEAD(&int_rs, rs, next);
sysctl_ctx_init(&rs->sysctl_ctx);
rl_sysctl_root = SYSCTL_ADD_NODE(&rs->sysctl_ctx,
SYSCTL_STATIC_CHILDREN(_net_inet_tcp_rl),
@@ -568,11 +563,10 @@
rs->rs_ifp->if_xname,
CTLFLAG_RW, 0,
"");
- /* Unlock to allow the sysctl stuff to allocate */
- mtx_unlock(&rs_mtx);
rl_add_syctl_entries(rl_sysctl_root, rs);
- /* re-lock for our caller */
mtx_lock(&rs_mtx);
+ CK_LIST_INSERT_HEAD(&int_rs, rs, next);
+ mtx_unlock(&rs_mtx);
return (rs);
}
@@ -978,8 +972,8 @@
return;
}
}
- rt_setup_new_rs(ifp, &error);
mtx_unlock(&rs_mtx);
+ rt_setup_new_rs(ifp, &error);
}
static void
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 17, 9:49 AM (4 h, 15 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
41797046
Default Alt Text
D21416.1794908945.diff (1 KB)
Attached To
Mode
D21416: Improve locking in tcp_ratelimit.c
Attached
Detach File
Event Timeline