Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F177570689
D61551.1794768164.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Authored By
Unknown
Size
988 B
Referenced Files
None
Subscribers
None
D61551.1794768164.diff
View Options
diff --git a/usr.sbin/ctld/nvmf.cc b/usr.sbin/ctld/nvmf.cc
--- a/usr.sbin/ctld/nvmf.cc
+++ b/usr.sbin/ctld/nvmf.cc
@@ -451,15 +451,22 @@
if (error != 0) {
log_warnc(error,
"Failed to prepare NVMe I/O qpair for handoff");
+ nvmf_connect_generic_error(nc, NVME_SC_INTERNAL_DEVICE_ERROR);
return;
}
- if (ioctl(ctl_fd, CTL_NVMF, &req) != 0)
+ if (ioctl(ctl_fd, CTL_NVMF, &req) != 0) {
log_warn("ioctl(CTL_NVMF/CTL_NVMF_HANDOFF)");
- if (req.status == CTL_NVMF_ERROR)
+ nvmf_connect_generic_error(nc, NVME_SC_INTERNAL_DEVICE_ERROR);
+ return;
+ }
+ if (req.status == CTL_NVMF_ERROR) {
log_warnx("Failed to handoff NVMF connection: %s",
req.error_str);
- else if (req.status != CTL_NVMF_OK)
+ nvmf_connect_generic_error(nc, NVME_SC_INTERNAL_DEVICE_ERROR);
+ } else if (req.status != CTL_NVMF_OK) {
log_warnx("Failed to handoff NVMF connection with status %d",
req.status);
+ nvmf_connect_generic_error(nc, NVME_SC_INTERNAL_DEVICE_ERROR);
+ }
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 15, 6:42 PM (23 h, 43 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
41746153
Default Alt Text
D61551.1794768164.diff (988 B)
Attached To
Mode
D61551: ctld nvmf: Return a generic internal error response if queue handoff fails
Attached
Detach File
Event Timeline