Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F177127154
D60417.1793849778.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Authored By
Unknown
Size
1 KB
Referenced Files
None
Subscribers
None
D60417.1793849778.diff
View Options
diff --git a/sys/arm64/arm64/pmap.c b/sys/arm64/arm64/pmap.c
--- a/sys/arm64/arm64/pmap.c
+++ b/sys/arm64/arm64/pmap.c
@@ -2152,6 +2152,31 @@
isb();
}
+/*
+ * Invalidates any cached final-level TLB entry for the specified virtual
+ * address in the given virtual address space, but only on the current
+ * processor.
+ *
+ * The pmap_multiple_tlbi errata only affect broadcast invalidations.
+ */
+static __inline void
+pmap_s1_invalidate_page_local(pmap_t pmap, vm_offset_t va)
+{
+ uint64_t r;
+
+ PMAP_ASSERT_STAGE1(pmap);
+ dsb(nshst);
+ r = TLBI_VA(va);
+ if (pmap == kernel_pmap) {
+ __asm __volatile("tlbi vaale1, %0" : : "r" (r));
+ } else {
+ r |= ASID_TO_OPERAND(COOKIE_TO_ASID(pmap->pm_cookie));
+ __asm __volatile("tlbi vale1, %0" : : "r" (r));
+ }
+ dsb(nsh);
+ isb();
+}
+
static __inline void
pmap_s2_invalidate_page(pmap_t pmap, vm_offset_t va, bool final_only)
{
@@ -9965,11 +9990,16 @@
ptep = pmap_pte(pmap, far, &lvl);
if (ptep != NULL &&
((pte = pmap_load(ptep)) & ATTR_SW_DBM) != 0) {
+ /*
+ * A local invalidation suffices when enabling write
+ * access. At worst, a write using a stale read-only
+ * TLB entry on another processor triggers a fault,
+ * requiring its own local invalidation below.
+ */
if ((pte & ATTR_S1_AP_RW_BIT) ==
- ATTR_S1_AP(ATTR_S1_AP_RO)) {
+ ATTR_S1_AP(ATTR_S1_AP_RO))
pmap_clear_bits(ptep, ATTR_S1_AP_RW_BIT);
- pmap_s1_invalidate_page(pmap, far, true);
- }
+ pmap_s1_invalidate_page_local(pmap, far);
rv = KERN_SUCCESS;
}
PMAP_UNLOCK(pmap);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Nov 5, 3:36 AM (4 h, 56 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
40368471
Default Alt Text
D60417.1793849778.diff (1 KB)
Attached To
Mode
D60417: arm64 pmap_fault: a local TLB invalidation suffices when enabling write access
Attached
Detach File
Event Timeline