Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F175249147
D60464.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
676 B
Referenced Files
None
Subscribers
None
D60464.diff
View Options
diff --git a/sys/dev/sound/pci/maestro3.c b/sys/dev/sound/pci/maestro3.c
--- a/sys/dev/sound/pci/maestro3.c
+++ b/sys/dev/sound/pci/maestro3.c
@@ -1122,6 +1122,12 @@
uint8_t event;
event = m3_rd_1(sc, HW_VOL_COUNTER_MASTER);
+ /*
+ * The mixer_hwvol_*() functions can end up taking sound(4)'s
+ * channel lock, but m3_pchan_trigger() takes sc_lock with the
+ * channel lock already held, which can cause a LOR.
+ */
+ M3_UNLOCK(sc);
switch (event) {
case 0x99:
mixer_hwvol_mute(sc->dev);
@@ -1137,6 +1143,7 @@
default:
device_printf(sc->dev, "Unknown HWVOL event\n");
}
+ M3_LOCK(sc);
m3_wr_1(sc, HW_VOL_COUNTER_MASTER, 0x88);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Oct 10, 10:25 AM (15 h, 55 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
40484129
Default Alt Text
D60464.diff (676 B)
Attached To
Mode
D60464: snd_maestro3: Do not hold sc_lock across the hwvol handlers
Attached
Detach File
Event Timeline
Log In to Comment