Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F174779473
D26752.id78138.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D26752.id78138.diff
View Options
Index: sys/kern/subr_bus.c
===================================================================
--- sys/kern/subr_bus.c
+++ sys/kern/subr_bus.c
@@ -4956,18 +4956,19 @@
bus_child_pnpinfo_sb(device_t dev, struct sbuf *sb)
{
char *p;
- size_t space;
+ ssize_t space;
MPASS((sb->s_flags & SBUF_INCLUDENUL) == 0);
+ MPASS(sb->s_size >= sb->s_len);
if (sb->s_error != 0)
return (-1);
p = EOB(sb);
- *p = '\0'; /* sbuf buffer isn't NUL terminated until sbuf_finish() */
space = SPACE(sb);
if (space <= 1) {
sb->s_error = ENOMEM;
return (-1);
}
+ *p = '\0'; /* sbuf buffer isn't NUL terminated until sbuf_finish() */
bus_child_pnpinfo_str(dev, p, space);
sb->s_len += strlen(p);
return (0);
@@ -4985,18 +4986,19 @@
bus_child_location_sb(device_t dev, struct sbuf *sb)
{
char *p;
- size_t space;
+ ssize_t space;
MPASS((sb->s_flags & SBUF_INCLUDENUL) == 0);
+ MPASS(sb->s_size >= sb->s_len);
if (sb->s_error != 0)
return (-1);
p = EOB(sb);
- *p = '\0'; /* sbuf buffer isn't NUL terminated until sbuf_finish() */
space = SPACE(sb);
if (space <= 1) {
sb->s_error = ENOMEM;
return (-1);
}
+ *p = '\0'; /* sbuf buffer isn't NUL terminated until sbuf_finish() */
bus_child_location_str(dev, p, space);
sb->s_len += strlen(p);
return (0);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Oct 6, 10:56 PM (9 h, 56 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
40302163
Default Alt Text
D26752.id78138.diff (1 KB)
Attached To
Mode
D26752: newbus: use ssize_t to match sb's len and size, fix ordering of space check
Attached
Detach File
Event Timeline
Log In to Comment