D52862.diff
No OneTemporary
Actions

Size

1006 B

Referenced Files

None

Subscribers

None

D52862.diff
View Options

	diff --git a/sys/dev/thunderbolt/nhi.c b/sys/dev/thunderbolt/nhi.c
	--- a/sys/dev/thunderbolt/nhi.c
	+++ b/sys/dev/thunderbolt/nhi.c
	@@ -26,6 +26,12 @@
	* SUCH DAMAGE.
	*/

	+/*
	+ * Spec references are to the Universal Serial Bus 4 (USB4®) Specification
	+ * version 2.0, September 2024:
	+ * https://usb.org/document-library/usb4r-specification-v20
	+ */
	+
	#include "opt_thunderbolt.h"

	/* PCIe interface for Thunderbolt Native Host Interface (nhi) */
	@@ -1090,6 +1096,16 @@
	if ((r = trkr->ring) == NULL)
	return;

	+ /*
	+ * Need to read this necessarily to clear it; see 12.6.3.4.1. Disable
	+ * ISR Auto-Clear must be set to 0.
	+ *
	+ * XXX This might not be necessary on all platforms. It is on Pink
	+ * Sardine, but this was not being done previously so it might have
	+ * been working without this on whatever scottl@ was testing on.
	+ */
	+ nhi_read_reg(sc, NHI_ISR0);
	+
	/*
	* Process TX completions from the adapter. Only go through
	* the ring once to prevent unbounded looping.