Page MenuHomeFreeBSD
Files F171473287

D22946.id66073.diff
No OneTemporary
Actions

D22946.id66073.diff
View Options

Index: sys/dev/random/fortuna.c
===================================================================
--- sys/dev/random/fortuna.c
+++ sys/dev/random/fortuna.c
@@ -358,6 +358,13 @@
* during accumulation/reseeding and reading/regating.
*/
pl = event->he_destination % RANDOM_FORTUNA_NPOOLS;
+ /*
+ * If a VM generation ID changes (clone and play or VM rewind), we want
+ * to incorporate that as soon as possible. Override destingation pool
+ * for immediate next use.
+ */
+ if (event->he_source == RANDOM_PURE_VMGENID)
+ pl = 0;
/*
* We ignore low entropy static/counter fields towards the end of the
* he_event structure in order to increase measurable entropy when
Index: sys/dev/random/random_harvestq.c
===================================================================
--- sys/dev/random/random_harvestq.c
+++ sys/dev/random/random_harvestq.c
@@ -328,6 +328,7 @@
[RANDOM_PURE_CCP] = "PURE_CCP",
[RANDOM_PURE_DARN] = "PURE_DARN",
[RANDOM_PURE_TPM] = "PURE_TPM",
+ [RANDOM_PURE_VMGENID] = "VMGENID",
/* "ENTROPYSOURCE" */
};
Index: sys/dev/vmgenc/vmgenc_acpi.c
===================================================================
--- sys/dev/vmgenc/vmgenc_acpi.c
+++ sys/dev/vmgenc/vmgenc_acpi.c
@@ -52,12 +52,14 @@
#include <sys/malloc.h>
#include <sys/module.h>
#include <sys/mutex.h>
+#include <sys/random.h>
#include <sys/sysctl.h>
#include <sys/systm.h>
#include <contrib/dev/acpica/include/acpi.h>
#include <dev/acpica/acpivar.h>
+#include <dev/random/random_harvestq.h>
#include <dev/vmgenc/vmgenc_acpi.h>
#ifndef ACPI_NOTIFY_STATUS_CHANGED
@@ -79,6 +81,20 @@
uint8_t vmg_cache_guid[GUID_BYTES];
};
+static void
+vmgenc_harvest_all(const void *p, size_t sz)
+{
+ size_t nbytes;
+
+ while (sz > 0) {
+ nbytes = MIN(sz,
+ sizeof(((struct harvest_event *)0)->he_entropy));
+ random_harvest_direct(p, nbytes, RANDOM_PURE_VMGENID);
+ p = (const char *)p + nbytes;
+ sz -= nbytes;
+ }
+}
+
static void
vmgenc_status_changed(void *context)
{
@@ -97,6 +113,8 @@
/* Update cache. */
memcpy(sc->vmg_cache_guid, guid, GUID_BYTES);
+ vmgenc_harvest_all(sc->vmg_cache_guid, sizeof(sc->vmg_cache_guid));
+
EVENTHANDLER_INVOKE(acpi_vmgenc_event);
acpi_UserNotify("VMGenerationCounter", acpi_get_handle(dev), 0);
}
@@ -230,6 +248,9 @@
memcpy(sc->vmg_cache_guid, __DEVOLATILE(void *, sc->vmg_pguid),
sizeof(sc->vmg_cache_guid));
+ random_harvest_register_source(RANDOM_PURE_VMGENID);
+ vmgenc_harvest_all(sc->vmg_cache_guid, sizeof(sc->vmg_cache_guid));
+
AcpiInstallNotifyHandler(h, ACPI_DEVICE_NOTIFY, vmgenc_notify, dev);
return (0);
}
@@ -249,3 +270,4 @@
static devclass_t vmgenc_devclass;
DRIVER_MODULE(vmgenc, acpi, vmgenc_driver, vmgenc_devclass, NULL, NULL);
MODULE_DEPEND(vmgenc, acpi, 1, 1, 1);
+MODULE_DEPEND(vemgenc, random_harvestq, 1, 1, 1);
Index: sys/sys/random.h
===================================================================
--- sys/sys/random.h
+++ sys/sys/random.h
@@ -102,6 +102,7 @@
RANDOM_PURE_CCP,
RANDOM_PURE_DARN,
RANDOM_PURE_TPM,
+ RANDOM_PURE_VMGENID,
ENTROPYSOURCE
};
_Static_assert(ENTROPYSOURCE <= 32,

File Metadata

Mime Type
text/plain
Expires
Sat, Sep 12, 7:52 AM (5 h, 32 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
38777867
Default Alt Text
D22946.id66073.diff (3 KB)

Event Timeline