Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F170805271
D58948.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
854 B
Referenced Files
None
Subscribers
None
D58948.diff
View Options
diff --git a/sys/dev/ufshci/ufshci_req_queue.c b/sys/dev/ufshci/ufshci_req_queue.c
--- a/sys/dev/ufshci/ufshci_req_queue.c
+++ b/sys/dev/ufshci/ufshci_req_queue.c
@@ -270,8 +270,8 @@
error = ufshci_req_queue_response_is_error(req_queue, ocs,
&cpl.response_upiu);
- /* Retry for admin commands */
- retriable = req->is_admin;
+ /* Retry for admin commands. A failed controller must not retry. */
+ retriable = req->is_admin && !req_queue->ctrlr->is_failed;
retry = error && retriable &&
req->retries < req_queue->ctrlr->retry_count;
if (retry)
@@ -765,6 +765,9 @@
mtx_assert(&req_queue->qops.get_hw_queue(req_queue)->qlock, MA_OWNED);
+ if (req_queue->ctrlr->is_failed)
+ return (ENXIO);
+
error = req_queue->qops.reserve_slot(req_queue, &tr);
if (error != 0) {
ufshci_printf(req_queue->ctrlr, "Failed to get tracker");
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Sep 7, 6:11 PM (8 h, 10 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
36980618
Default Alt Text
D58948.diff (854 B)
Attached To
Mode
D58948: ufshci: reject new requests on a failed controller
Attached
Detach File
Event Timeline
Log In to Comment