Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F163361415
D27513.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
855 B
Referenced Files
None
Subscribers
None
D27513.diff
View Options
Index: head/sys/kern/kern_descrip.c
===================================================================
--- head/sys/kern/kern_descrip.c
+++ head/sys/kern/kern_descrip.c
@@ -2463,6 +2463,13 @@
struct file *fp;
int i, lastfile;
+ KASSERT(refcount_load(&fdp->fd_refcnt) == 0,
+ ("%s: fd table %p carries references", __func__, fdp));
+
+ /* Serialize with threads iterating over the table. */
+ FILEDESC_XLOCK(fdp);
+ FILEDESC_XUNLOCK(fdp);
+
lastfile = fdlastfile_single(fdp);
for (i = 0; i <= lastfile; i++) {
fde = &fdp->fd_ofiles[i];
@@ -2536,6 +2543,11 @@
void
fdescfree_remapped(struct filedesc *fdp)
{
+#ifdef INVARIANTS
+ /* fdescfree_fds() asserts that fd_refcnt == 0. */
+ if (!refcount_release(&fdp->fd_refcnt))
+ panic("%s: fd table %p has extra references", __func__, fdp);
+#endif
fdescfree_fds(curthread, fdp, 0);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Jul 23, 12:31 PM (12 h, 37 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
35402067
Default Alt Text
D27513.diff (855 B)
Attached To
Mode
D27513: fd: Plug a race between fd table free and several loops
Attached
Detach File
Event Timeline
Log In to Comment