Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F161319550
D32247.id96080.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D32247.id96080.diff
View Options
diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c
--- a/sys/dev/nvme/nvme_ctrlr.c
+++ b/sys/dev/nvme/nvme_ctrlr.c
@@ -52,6 +52,12 @@
static void nvme_ctrlr_construct_and_submit_aer(struct nvme_controller *ctrlr,
struct nvme_async_event_request *aer);
+static void
+nvme_ctrlr_barrier(struct nvme_controller *ctrlr, int flags)
+{
+ bus_barrier(ctrlr->resource, 0, rman_get_size(ctrlr->resource), flags);
+}
+
static void
nvme_ctrlr_devctl_log(struct nvme_controller *ctrlr, const char *type, const char *msg, ...)
{
@@ -356,9 +362,7 @@
}
nvme_mmio_write_8(ctrlr, asq, ctrlr->adminq.cmd_bus_addr);
- DELAY(5000);
nvme_mmio_write_8(ctrlr, acq, ctrlr->adminq.cpl_bus_addr);
- DELAY(5000);
/* acqs and asqs are 0-based. */
qsize = ctrlr->adminq.num_entries - 1;
@@ -367,7 +371,6 @@
aqa = (qsize & NVME_AQA_REG_ACQS_MASK) << NVME_AQA_REG_ACQS_SHIFT;
aqa |= (qsize & NVME_AQA_REG_ASQS_MASK) << NVME_AQA_REG_ASQS_SHIFT;
nvme_mmio_write_4(ctrlr, aqa, aqa);
- DELAY(5000);
/* Initialization values for CC */
cc = 0;
@@ -381,6 +384,7 @@
/* This evaluates to 0, which is according to spec. */
cc |= (PAGE_SIZE >> 13) << NVME_CC_REG_MPS_SHIFT;
+ nvme_ctrlr_barrier(ctrlr, BUS_SPACE_BARRIER_WRITE);
nvme_mmio_write_4(ctrlr, cc, cc);
return (nvme_ctrlr_wait_for_ready(ctrlr, 1));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Jul 3, 6:48 PM (11 h, 47 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
34633739
Default Alt Text
D32247.id96080.diff (1 KB)
Attached To
Mode
D32247: nvme_ctrlr_enable: Remove delays
Attached
Detach File
Event Timeline
Log In to Comment