Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F157037089
D7363.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D7363.diff
View Options
Index: head/sys/x86/x86/intr_machdep.c
===================================================================
--- head/sys/x86/x86/intr_machdep.c
+++ head/sys/x86/x86/intr_machdep.c
@@ -197,28 +197,19 @@
intr_remove_handler(void *cookie)
{
struct intsrc *isrc;
- int error, mtx_owned;
+ int error;
isrc = intr_handler_source(cookie);
error = intr_event_remove_handler(cookie);
if (error == 0) {
- /*
- * Recursion is needed here so PICs can remove interrupts
- * while resuming. It was previously not possible due to
- * intr_resume holding the intr_table_lock and
- * intr_remove_handler recursing on it.
- */
- mtx_owned = mtx_owned(&intr_table_lock);
- if (mtx_owned == 0)
- mtx_lock(&intr_table_lock);
+ mtx_lock(&intr_table_lock);
isrc->is_handlers--;
if (isrc->is_handlers == 0) {
isrc->is_pic->pic_disable_source(isrc, PIC_NO_EOI);
isrc->is_pic->pic_disable_intr(isrc);
}
intrcnt_updatename(isrc);
- if (mtx_owned == 0)
- mtx_unlock(&intr_table_lock);
+ mtx_unlock(&intr_table_lock);
}
return (error);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, May 19, 1:57 AM (21 h, 51 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
33284902
Default Alt Text
D7363.diff (1 KB)
Attached To
Mode
D7363: Revert r291022: x86/intr: allow mutex recursion in intr_remove_handler
Attached
Detach File
Event Timeline
Log In to Comment