Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F153999452
D11815.id31457.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D11815.id31457.diff
View Options
Index: sys/kern/subr_blist.c
===================================================================
--- sys/kern/subr_blist.c
+++ sys/kern/subr_blist.c
@@ -151,17 +151,18 @@
* in the 'meta' functions that process subtrees. Since integer division
* discards remainders, we can express this computation as
* skip = (m * m**h) / (m - 1)
- * skip = (m * radix / BLIST_BMAP_RADIX) / (m - 1)
+ * skip = (m * (radix / BLIST_BMAP_RADIX)) / (m - 1)
* and if m divides BLIST_BMAP_RADIX, we can simplify further to
- * skip = radix / (BLIST_BMAP_RADIX / m * (m - 1))
- * so that a simple integer division is enough for the calculation.
+ * skip = (radix / (BLIST_BMAP_RADIX / m)) / (m - 1)
+ * skip = radix / ((BLIST_BMAP_RADIX / m) * (m - 1))
+ * so that simple integer division by a constant is enough for the calculation.
*/
static inline daddr_t
radix_to_skip(daddr_t radix)
{
return (radix /
- (BLIST_BMAP_RADIX / BLIST_META_RADIX * (BLIST_META_RADIX - 1)));
+ ((BLIST_BMAP_RADIX / BLIST_META_RADIX) * (BLIST_META_RADIX - 1)));
}
/*
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Apr 26, 8:48 AM (17 h, 36 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
32135894
Default Alt Text
D11815.id31457.diff (1 KB)
Attached To
Mode
D11815: Add parens to radix_to_skip for reader clarity
Attached
Detach File
Event Timeline
Log In to Comment