Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F153573075
D29838.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
2 KB
Referenced Files
None
Subscribers
None
D29838.diff
View Options
diff --git a/sys/netinet/ip_divert.c b/sys/netinet/ip_divert.c
--- a/sys/netinet/ip_divert.c
+++ b/sys/netinet/ip_divert.c
@@ -212,11 +212,17 @@
/* Delayed checksums are currently not compatible with divert. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
+ m = mb_unmapped_to_ext(m);
+ if (m == NULL)
+ return;
in_delayed_cksum(m);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
}
#if defined(SCTP) || defined(SCTP_SUPPORT)
if (m->m_pkthdr.csum_flags & CSUM_SCTP) {
+ m = mb_unmapped_to_ext(m);
+ if (m == NULL)
+ return;
sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2));
m->m_pkthdr.csum_flags &= ~CSUM_SCTP;
}
diff --git a/sys/netpfil/ipfw/ip_fw_nat.c b/sys/netpfil/ipfw/ip_fw_nat.c
--- a/sys/netpfil/ipfw/ip_fw_nat.c
+++ b/sys/netpfil/ipfw/ip_fw_nat.c
@@ -307,6 +307,7 @@
args->m = NULL;
return (IP_FW_DENY);
}
+ M_ASSERTMAPPED(mcl);
ip = mtod(mcl, struct ip *);
/*
diff --git a/sys/netpfil/ipfw/nat64/nat64_translate.c b/sys/netpfil/ipfw/nat64/nat64_translate.c
--- a/sys/netpfil/ipfw/nat64/nat64_translate.c
+++ b/sys/netpfil/ipfw/nat64/nat64_translate.c
@@ -1296,6 +1296,11 @@
/* Handle delayed checksums if needed. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
+ m = mb_unmapped_to_ext(m);
+ if (m == NULL) {
+ NAT64STAT_INC(&cfg->stats, nomem);
+ return (NAT64RETURN);
+ }
in_delayed_cksum(m);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
}
@@ -1673,6 +1678,11 @@
/* Handle delayed checksums if needed. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA_IPV6) {
+ m = mb_unmapped_to_ext(m);
+ if (m == NULL) {
+ NAT64STAT_INC(&cfg->stats, nomem);
+ return (NAT64RETURN);
+ }
in6_delayed_cksum(m, plen, hlen);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA_IPV6;
}
diff --git a/sys/sys/mbuf.h b/sys/sys/mbuf.h
--- a/sys/sys/mbuf.h
+++ b/sys/sys/mbuf.h
@@ -1113,6 +1113,17 @@
KASSERT((((struct mbuf *)m)->m_flags & 0) == 0, \
("%s: attempted use of a free mbuf!", __func__))
+/* Check whether any mbuf in the chain is unmapped. */
+#ifdef INVARIANTS
+#define M_ASSERTMAPPED(m) do { \
+ for (struct mbuf *__m = (m); __m != NULL; __m = __m->m_next) \
+ KASSERT((__m->m_flags & M_EXTPG) == 0, \
+ ("%s: chain %p contains an unmapped mbuf", __func__, (m)));\
+} while (0)
+#else
+#define M_ASSERTMAPPED(m)
+#endif
+
/*
* Return the address of the start of the buffer associated with an mbuf,
* handling external storage, packet-header mbufs, and regular data mbufs.
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Apr 23, 12:53 AM (15 h, 30 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
32005346
Default Alt Text
D29838.diff (2 KB)
Attached To
Mode
D29838: Add more checking for unmapped mbufs
Attached
Detach File
Event Timeline
Log In to Comment