Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F153480373
D22611.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
4 KB
Referenced Files
None
Subscribers
None
D22611.diff
View Options
Index: head/sys/amd64/sgx/sgx.c
===================================================================
--- head/sys/amd64/sgx/sgx.c
+++ head/sys/amd64/sgx/sgx.c
@@ -389,14 +389,16 @@
* First remove all the pages except SECS,
* then remove SECS page.
*/
- p_secs = NULL;
+restart:
TAILQ_FOREACH_SAFE(p, &object->memq, listq, p_next) {
- if (p->pindex == SGX_SECS_VM_OBJECT_INDEX) {
- p_secs = p;
+ if (p->pindex == SGX_SECS_VM_OBJECT_INDEX)
continue;
- }
+ if (vm_page_busy_acquire(p, VM_ALLOC_WAITFAIL) == 0)
+ goto restart;
sgx_page_remove(sc, p);
}
+ p_secs = vm_page_grab(object, SGX_SECS_VM_OBJECT_INDEX,
+ VM_ALLOC_NOCREAT);
/* Now remove SECS page */
if (p_secs != NULL)
sgx_page_remove(sc, p_secs);
@@ -723,8 +725,9 @@
if ((sc->state & SGX_STATE_RUNNING) == 0) {
mtx_unlock(&sc->mtx);
/* Remove VA page that was just created for SECS page. */
- p = vm_page_lookup(enclave->object,
- - SGX_VA_PAGES_OFFS - SGX_SECS_VM_OBJECT_INDEX);
+ p = vm_page_grab(enclave->object,
+ - SGX_VA_PAGES_OFFS - SGX_SECS_VM_OBJECT_INDEX,
+ VM_ALLOC_NOCREAT);
sgx_page_remove(sc, p);
VM_OBJECT_WUNLOCK(object);
goto error;
@@ -736,8 +739,9 @@
dprintf("%s: gp fault\n", __func__);
mtx_unlock(&sc->mtx);
/* Remove VA page that was just created for SECS page. */
- p = vm_page_lookup(enclave->object,
- - SGX_VA_PAGES_OFFS - SGX_SECS_VM_OBJECT_INDEX);
+ p = vm_page_grab(enclave->object,
+ - SGX_VA_PAGES_OFFS - SGX_SECS_VM_OBJECT_INDEX,
+ VM_ALLOC_NOCREAT);
sgx_page_remove(sc, p);
VM_OBJECT_WUNLOCK(object);
goto error;
Index: head/sys/arm/nvidia/drm2/tegra_bo.c
===================================================================
--- head/sys/arm/nvidia/drm2/tegra_bo.c
+++ head/sys/arm/nvidia/drm2/tegra_bo.c
@@ -64,6 +64,7 @@
VM_OBJECT_WLOCK(bo->cdev_pager);
for (i = 0; i < bo->npages; i++) {
m = bo->m[i];
+ vm_page_busy_acquire(m, 0);
cdev_pager_free_page(bo->cdev_pager, m);
m->flags &= ~PG_FICTITIOUS;
vm_page_unwire_noq(m);
Index: head/sys/dev/md/md.c
===================================================================
--- head/sys/dev/md/md.c
+++ head/sys/dev/md/md.c
@@ -1024,14 +1024,6 @@
return (error);
}
-static void
-md_swap_page_free(vm_page_t m)
-{
-
- vm_page_xunbusy(m);
- vm_page_free(m);
-}
-
static int
mdstart_swap(struct md_s *sc, struct bio *bp)
{
@@ -1080,7 +1072,7 @@
rv = vm_pager_get_pages(sc->object, &m, 1,
NULL, NULL);
if (rv == VM_PAGER_ERROR) {
- md_swap_page_free(m);
+ vm_page_free(m);
break;
} else if (rv == VM_PAGER_FAIL) {
/*
@@ -1110,7 +1102,7 @@
rv = vm_pager_get_pages(sc->object, &m, 1,
NULL, NULL);
if (rv == VM_PAGER_ERROR) {
- md_swap_page_free(m);
+ vm_page_free(m);
break;
} else if (rv == VM_PAGER_FAIL)
pmap_zero_page(m);
@@ -1137,10 +1129,10 @@
rv = vm_pager_get_pages(sc->object, &m, 1,
NULL, NULL);
if (rv == VM_PAGER_ERROR) {
- md_swap_page_free(m);
+ vm_page_free(m);
break;
} else if (rv == VM_PAGER_FAIL) {
- md_swap_page_free(m);
+ vm_page_free(m);
m = NULL;
} else {
/* Page is valid. */
@@ -1152,7 +1144,7 @@
}
} else {
vm_pager_page_unswapped(m);
- md_swap_page_free(m);
+ vm_page_free(m);
m = NULL;
}
}
Index: head/sys/vm/vm_glue.c
===================================================================
--- head/sys/vm/vm_glue.c
+++ head/sys/vm/vm_glue.c
@@ -363,6 +363,7 @@
m = vm_page_lookup(ksobj, i);
if (m == NULL)
panic("%s: kstack already missing?", __func__);
+ vm_page_busy_acquire(m, 0);
vm_page_unwire_noq(m);
vm_page_free(m);
}
Index: head/sys/x86/iommu/intel_utils.c
===================================================================
--- head/sys/x86/iommu/intel_utils.c
+++ head/sys/x86/iommu/intel_utils.c
@@ -298,7 +298,7 @@
if ((flags & DMAR_PGF_OBJL) == 0)
VM_OBJECT_WLOCK(obj);
- m = vm_page_lookup(obj, idx);
+ m = vm_page_grab(obj, idx, VM_ALLOC_NOCREAT);
if (m != NULL) {
vm_page_free(m);
atomic_subtract_int(&dmar_tbl_pagecnt, 1);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Apr 22, 9:53 AM (13 h, 25 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
31969613
Default Alt Text
D22611.diff (4 KB)
Attached To
Mode
D22611: Fix a few places that free a page from an object without busy held.
Attached
Detach File
Event Timeline
Log In to Comment