Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F153343688
D25441.id73663.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
4 KB
Referenced Files
None
Subscribers
None
D25441.id73663.diff
View Options
Index: head/sys/geom/bde/g_bde.c
===================================================================
--- head/sys/geom/bde/g_bde.c
+++ head/sys/geom/bde/g_bde.c
@@ -88,7 +88,7 @@
gp->flags |= G_GEOM_WITHER;
LIST_FOREACH(pp, &gp->provider, provider)
g_wither_provider(pp, ENXIO);
- bzero(sc, sizeof(struct g_bde_softc)); /* destroy evidence */
+ explicit_bzero(sc, sizeof(struct g_bde_softc)); /* destroy evidence */
return;
}
@@ -163,7 +163,7 @@
error = g_bde_decrypt_lock(sc, pass, key,
mediasize, sectorsize, NULL);
- bzero(sc->sha2, sizeof sc->sha2);
+ explicit_bzero(sc->sha2, sizeof sc->sha2);
if (error)
break;
kp = &sc->key;
@@ -195,9 +195,9 @@
break;
} while (0);
if (pass != NULL)
- bzero(pass, SHA512_DIGEST_LENGTH);
+ explicit_bzero(pass, SHA512_DIGEST_LENGTH);
if (key != NULL)
- bzero(key, 16);
+ explicit_bzero(key, 16);
if (error == 0)
return;
g_access(cp, -1, -1, -1);
@@ -255,7 +255,7 @@
while (sc->dead != 2 && !LIST_EMPTY(&pp->consumers))
tsleep(sc, PRIBIO, "g_bdedie", hz);
mtx_destroy(&sc->worklist_mutex);
- bzero(&sc->key, sizeof sc->key);
+ explicit_bzero(&sc->key, sizeof sc->key);
g_free(sc);
g_wither_geom(gp, ENXIO);
return (0);
Index: head/sys/geom/bde/g_bde_lock.c
===================================================================
--- head/sys/geom/bde/g_bde_lock.c
+++ head/sys/geom/bde/g_bde_lock.c
@@ -316,9 +316,9 @@
AES_init(&ci);
AES_makekey(&ki, DIR_ENCRYPT, G_BDE_KKEYBITS, sha2 + 0);
AES_encrypt(&ci, &ki, buf, output, sizeof buf);
- bzero(buf, sizeof buf);
- bzero(&ci, sizeof ci);
- bzero(&ki, sizeof ki);
+ explicit_bzero(buf, sizeof buf);
+ explicit_bzero(&ci, sizeof ci);
+ explicit_bzero(&ki, sizeof ki);
return (0);
}
@@ -333,9 +333,9 @@
AES_makekey(&ki, DIR_DECRYPT, G_BDE_KKEYBITS, sha2 + 0);
AES_decrypt(&ci, &ki, input, buf, sizeof buf);
*output = le64dec(buf);
- bzero(buf, sizeof buf);
- bzero(&ci, sizeof ci);
- bzero(&ki, sizeof ki);
+ explicit_bzero(buf, sizeof buf);
+ explicit_bzero(&ci, sizeof ci);
+ explicit_bzero(&ki, sizeof ki);
return(0);
}
Index: head/sys/geom/eli/g_eli.c
===================================================================
--- head/sys/geom/eli/g_eli.c
+++ head/sys/geom/eli/g_eli.c
@@ -1126,7 +1126,7 @@
data = preload_fetch_addr(keyfile);
size = preload_fetch_size(keyfile);
if (data != NULL && size != 0)
- bzero(data, size);
+ explicit_bzero(data, size);
}
}
@@ -1261,7 +1261,7 @@
pkcs5v2_genkey(dkey, sizeof(dkey), md.md_salt,
sizeof(md.md_salt), passphrase, md.md_iterations);
- bzero(passphrase, sizeof(passphrase));
+ explicit_bzero(passphrase, sizeof(passphrase));
g_eli_crypto_hmac_update(&ctx, dkey, sizeof(dkey));
explicit_bzero(dkey, sizeof(dkey));
}
@@ -1272,7 +1272,7 @@
* Decrypt Master-Key.
*/
error = g_eli_mkey_decrypt_any(&md, key, mkey, &nkey);
- bzero(key, sizeof(key));
+ explicit_bzero(key, sizeof(key));
if (error == -1) {
if (i == tries) {
G_ELI_DEBUG(0,
@@ -1305,8 +1305,8 @@
* We have correct key, let's attach provider.
*/
gp = g_eli_create(NULL, mp, pp, &md, mkey, nkey);
- bzero(mkey, sizeof(mkey));
- bzero(&md, sizeof(md));
+ explicit_bzero(mkey, sizeof(mkey));
+ explicit_bzero(&md, sizeof(md));
if (gp == NULL) {
G_ELI_DEBUG(0, "Cannot create device %s%s.", pp->name,
G_ELI_SUFFIX);
Index: head/sys/geom/shsec/g_shsec.c
===================================================================
--- head/sys/geom/shsec/g_shsec.c
+++ head/sys/geom/shsec/g_shsec.c
@@ -269,7 +269,7 @@
(ssize_t)pbp->bio_length);
}
}
- bzero(bp->bio_data, bp->bio_length);
+ explicit_bzero(bp->bio_data, bp->bio_length);
uma_zfree(g_shsec_zone, bp->bio_data);
g_destroy_bio(bp);
pbp->bio_inbed++;
@@ -384,7 +384,7 @@
TAILQ_REMOVE(&queue, cbp, bio_queue);
bp->bio_children--;
if (cbp->bio_data != NULL) {
- bzero(cbp->bio_data, cbp->bio_length);
+ explicit_bzero(cbp->bio_data, cbp->bio_length);
uma_zfree(g_shsec_zone, cbp->bio_data);
}
g_destroy_bio(cbp);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Apr 21, 2:38 PM (7 h, 33 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
31829214
Default Alt Text
D25441.id73663.diff (4 KB)
Attached To
Mode
D25441: Use explicit_bzero() instead of bzero() for sensitive data.
Attached
Detach File
Event Timeline
Log In to Comment