Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F153260291
D19016.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D19016.id.diff
View Options
Index: usr.sbin/bhyve/bhyverun.c
===================================================================
--- usr.sbin/bhyve/bhyverun.c
+++ usr.sbin/bhyve/bhyverun.c
@@ -233,8 +233,8 @@
" -W: force virtio to use single-vector MSI\n"
" -x: local apic is in x2APIC mode\n"
" -Y: disable MPtable generation\n",
- progname, (int)strlen(progname), "", (int)strlen(progname), "",
- (int)strlen(progname), "");
+ progname, (int)strnlen(progname, PATH_MAX), "", (int)strnlen(progname, PATH_MAX), "",
+ (int)strnlen(progname, PATH_MAX), "");
exit(code);
}
Index: usr.sbin/bhyve/smbiostbl.c
===================================================================
--- usr.sbin/bhyve/smbiostbl.c
+++ usr.sbin/bhyve/smbiostbl.c
@@ -558,7 +558,7 @@
int len;
string = template_strings[i];
- len = strlen(string) + 1;
+ len = strnlen(string, SMBIOS_MAX_LENGTH) + 1;
memcpy(curaddr, string, len);
curaddr += len;
}
@@ -611,7 +611,7 @@
return (-1);
MD5Init(&mdctx);
- MD5Update(&mdctx, vmname, strlen(vmname));
+ MD5Update(&mdctx, vmname, strnlen(vmname, PATH_MAX));
MD5Update(&mdctx, hostname, sizeof(hostname));
MD5Final(digest, &mdctx);
Index: usr.sbin/bhyve/usb_mouse.c
===================================================================
--- usr.sbin/bhyve/usb_mouse.c
+++ usr.sbin/bhyve/usb_mouse.c
@@ -70,6 +70,7 @@
UMSTR_MAX
};
+#define UMOUSE_DESC_MAX_LEN 32
static const char *umouse_desc_strings[] = {
"\x04\x09",
"BHYVE",
@@ -441,7 +442,7 @@
goto done;
}
- slen = 2 + strlen(str) * 2;
+ slen = 2 + strnlen(str, UMOUSE_DESC_MAX_LEN) * 2;
udata[0] = slen;
udata[1] = UDESC_STRING;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Apr 21, 3:02 AM (7 h, 42 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
31883117
Default Alt Text
D19016.id.diff (1 KB)
Attached To
Mode
D19016: Replace strlen with strnlen.
Attached
Detach File
Event Timeline
Log In to Comment