Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F153211321
D10022.id26434.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D10022.id26434.diff
View Options
Index: lib/libkvm/kvm.c
===================================================================
--- lib/libkvm/kvm.c
+++ lib/libkvm/kvm.c
@@ -52,6 +52,7 @@
#include <net/vnet.h>
+#include <errno.h>
#include <fcntl.h>
#include <kvm.h>
#include <limits.h>
@@ -69,6 +70,9 @@
char *
kvm_geterr(kvm_t *kd)
{
+
+ if (kd == NULL)
+ return (strerror(EINVAL));
return (kd->errbuf);
}
@@ -272,6 +276,10 @@
{
int error = 0;
+ if (kd == NULL) {
+ errno = EINVAL;
+ return (-1);
+ }
if (kd->vmst != NULL)
kd->arch->ka_freevtop(kd);
if (kd->pmfd >= 0)
@@ -292,7 +300,7 @@
free(kd->pt_map);
free((void *)kd);
- return (0);
+ return (error);
}
int
Index: lib/libkvm/kvm_geterr.3
===================================================================
--- lib/libkvm/kvm_geterr.3
+++ lib/libkvm/kvm_geterr.3
@@ -32,7 +32,7 @@
.\" @(#)kvm_geterr.3 8.1 (Berkeley) 6/4/93
.\" $FreeBSD$
.\"
-.Dd June 4, 1993
+.Dd March 15, 2017
.Dt KVM_GETERR 3
.Os
.Sh NAME
@@ -54,6 +54,15 @@
The string returned is stored in memory owned by
.Xr kvm 3
so the message should be copied out and saved elsewhere if necessary.
+.Sh RETURN VALUES
+The function
+.Fn kvm_geterr
+will return "" if
+.Fa kd
+is
+.Dv NULL
+or an error has not been captured for
+.Fa kd .
.Sh SEE ALSO
.Xr kvm 3 ,
.Xr kvm_close 3 ,
Index: lib/libkvm/kvm_open.3
===================================================================
--- lib/libkvm/kvm_open.3
+++ lib/libkvm/kvm_open.3
@@ -227,10 +227,29 @@
write the error message into
.Fa errbuf .
.Pp
+.Rv -std kvm_close
+.Sh ERRORS
The
.Fn kvm_close
-function returns 0 on success and -1 on failure.
+function may fail and set the global variable
+.Va errno
+for any of the errors specified for
+.Xr close 2 .
+.Pp
+The
+.Fn kvm_close
+function may also fail and set
+.Va errno
+if:
+.Bl -tag -width Er
+.It Bq Er EINVAL
+The value passed via
+.Fa *kd
+was
+.Dv NULL .
+.El
.Sh SEE ALSO
+.Xr close 2 ,
.Xr open 2 ,
.Xr kvm 3 ,
.Xr kvm_getargv 3 ,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Apr 20, 8:18 PM (1 h, 16 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
31862295
Default Alt Text
D10022.id26434.diff (1 KB)
Attached To
Mode
D10022: Handle kd == NULL gracefully with kvm_geterr(3)
Attached
Detach File
Event Timeline
Log In to Comment