D56318.diff
No OneTemporary
Actions

Size

877 B

Referenced Files

None

Subscribers

None

D56318.diff
View Options

	diff --git a/sys/kern/kern_event.c b/sys/kern/kern_event.c
	--- a/sys/kern/kern_event.c
	+++ b/sys/kern/kern_event.c
	@@ -1822,12 +1822,6 @@
	kn->kn_fp = fp;
	kn->kn_kq = kq;
	kn->kn_fop = fops;
	- /*
	- * apply reference counts to knote structure, and
	- * do not release it at the end of this routine.
	- */
	- fops = NULL;
	- fp = NULL;

	kn->kn_sfflags = kev->fflags;
	kn->kn_sdata = kev->data;
	@@ -1848,6 +1842,16 @@
	goto done;
	}

	+ /*
	+ * We transfer ownership of fops/fp to the knote
	+ * structure and avoid releasing them at the end of
	+ * this routine, now that all of the remaining exit
	+ * paths will knote_drop() to release the reference
	+ * counts we held on them above.
	+ */
	+ fops = NULL;
	+ fp = NULL;
	+
	if ((error = kn->kn_fop->f_attach(kn)) != 0) {
	knote_drop_detached(kn, td);
	goto done;