Page MenuHomeFreeBSD

D3522.id8379.diff
No OneTemporary

D3522.id8379.diff

Index: sys/arm/arm/busdma_machdep.c
===================================================================
--- sys/arm/arm/busdma_machdep.c
+++ sys/arm/arm/busdma_machdep.c
@@ -124,14 +124,16 @@
vm_offset_t vaddr; /* kva of bounce buffer */
bus_addr_t busaddr; /* Physical address */
vm_offset_t datavaddr; /* kva of client data */
- bus_addr_t dataaddr; /* client physical address */
+ vm_page_t datapage; /* physical page of client data */
+ vm_offset_t dataoffs; /* page offset of client data */
bus_size_t datacount; /* client data count */
STAILQ_ENTRY(bounce_page) links;
};
struct sync_list {
vm_offset_t vaddr; /* kva of bounce buffer */
- bus_addr_t busaddr; /* Physical address */
+ vm_page_t pages; /* starting page of client data */
+ vm_offset_t dataoffs; /* page offset of client data */
bus_size_t datacount; /* client data count */
};
@@ -197,6 +199,8 @@
vm_offset_t vaddr, bus_addr_t addr,
bus_size_t size);
static void free_bounce_page(bus_dma_tag_t dmat, struct bounce_page *bpage);
+static void bus_dmamap_sync_sl(struct sync_list *sl, bus_dmasync_op_t op,
+ int bufaligned);
/* Default tag, as most drivers provide no parent tag. */
bus_dma_tag_t arm_root_dma_tag;
@@ -950,6 +954,7 @@
_bus_dmamap_load_phys(bus_dma_tag_t dmat, bus_dmamap_t map, vm_paddr_t buf,
bus_size_t buflen, int flags, bus_dma_segment_t *segs, int *segp)
{
+ struct sync_list *sl;
bus_size_t sgsize;
bus_addr_t curaddr;
int error;
@@ -974,6 +979,21 @@
sgsize = MIN(sgsize, PAGE_SIZE);
curaddr = add_bounce_page(dmat, map, 0, curaddr,
sgsize);
+ } else {
+ sl = map->slist + map->sync_count - 1;
+ if (map->sync_count == 0 ||
+ curaddr != VM_PAGE_TO_PHYS(sl->pages) +
+ sl->dataoffs + sl->datacount) {
+
+ if (++map->sync_count > dmat->nsegments)
+ break;
+ sl++;
+ sl->vaddr = 0;
+ sl->datacount = sgsize;
+ sl->pages = PHYS_TO_VM_PAGE(curaddr & ~PAGE_MASK);
+ sl->dataoffs = curaddr & PAGE_MASK;
+ } else
+ sl->datacount += sgsize;
}
sgsize = _bus_dmamap_addseg(dmat, map, curaddr, sgsize, segs,
segp);
@@ -1015,7 +1035,7 @@
bus_size_t sgsize;
bus_addr_t curaddr;
struct sync_list *sl;
- vm_offset_t vaddr = (vm_offset_t)buf;
+ vm_offset_t kvaddr, vaddr = (vm_offset_t)buf;
int error = 0;
if (segs == NULL)
@@ -1040,9 +1060,11 @@
*/
if (__predict_true(pmap == kernel_pmap)) {
curaddr = pmap_kextract(vaddr);
+ kvaddr = vaddr;
} else {
curaddr = pmap_extract(pmap, vaddr);
map->flags &= ~DMAMAP_COHERENT;
+ kvaddr = 0;
}
/*
@@ -1056,18 +1078,25 @@
if (((dmat->flags & BUS_DMA_COULD_BOUNCE) != 0) &&
map->pagesneeded != 0 && run_filter(dmat, curaddr)) {
- curaddr = add_bounce_page(dmat, map, vaddr, curaddr,
+ curaddr = add_bounce_page(dmat, map, kvaddr, curaddr,
sgsize);
} else {
- sl = &map->slist[map->sync_count - 1];
+ sl = map->slist + map->sync_count - 1;
+
if (map->sync_count == 0 ||
- vaddr != sl->vaddr + sl->datacount) {
+ (kvaddr != 0 &&
+ kvaddr != sl->vaddr + sl->datacount) ||
+ (kvaddr == 0 &&
+ curaddr != VM_PAGE_TO_PHYS(sl->pages) +
+ sl->dataoffs + sl->datacount)) {
+
if (++map->sync_count > dmat->nsegments)
goto cleanup;
sl++;
- sl->vaddr = vaddr;
+ sl->vaddr = kvaddr;
sl->datacount = sgsize;
- sl->busaddr = curaddr;
+ sl->pages = PHYS_TO_VM_PAGE(curaddr & ~PAGE_MASK);
+ sl->dataoffs = curaddr & PAGE_MASK;
} else
sl->datacount += sgsize;
}
@@ -1199,33 +1228,75 @@
}
static void
+bus_dmamap_sync_sl(struct sync_list *sl, bus_dmasync_op_t op,
+ int bufaligned)
+{
+ bus_size_t synccount, pagecount;
+ vm_offset_t syncoffs, tempvaddr;
+ vm_page_t curpage;
+
+ if (sl->vaddr == 0) {
+ bus_dmamap_sync_buf(sl->vaddr, sl->datacount, op, bufaligned);
+ return;
+ }
+
+ synccount = sl->datacount;
+ syncoffs = sl->dataoffs;
+ tempvaddr = 0;
+ curpage = sl->pages;
+
+ while (synccount > 0) {
+ pagecount = MIN(PAGE_SIZE - syncoffs, synccount);
+ tempvaddr = pmap_quick_enter_page(curpage);
+ bus_dmamap_sync_buf(tempvaddr | syncoffs, pagecount,
+ op, bufaligned);
+ pmap_quick_remove_page(tempvaddr);
+ syncoffs = 0;
+ synccount -= pagecount;
+ ++curpage;
+ }
+}
+
+static void
_bus_dmamap_sync_bp(bus_dma_tag_t dmat, bus_dmamap_t map, bus_dmasync_op_t op)
{
struct bounce_page *bpage;
+ vm_offset_t datavaddr, tempvaddr;
+
+ if ((op & (BUS_DMASYNC_PREWRITE | BUS_DMASYNC_POSTREAD)) == 0)
+ return;
STAILQ_FOREACH(bpage, &map->bpages, links) {
+ tempvaddr = 0;
+ datavaddr = bpage->datavaddr;
+ if (datavaddr == 0) {
+ tempvaddr = pmap_quick_enter_page(bpage->datapage);
+ datavaddr = tempvaddr | bpage->dataoffs;
+ }
if (op & BUS_DMASYNC_PREWRITE) {
- if (bpage->datavaddr != 0)
- bcopy((void *)bpage->datavaddr,
- (void *)bpage->vaddr, bpage->datacount);
- else
- physcopyout(bpage->dataaddr,
- (void *)bpage->vaddr,bpage->datacount);
- cpu_dcache_wb_range(bpage->vaddr, bpage->datacount);
- cpu_l2cache_wb_range(bpage->vaddr, bpage->datacount);
+ bcopy((void *)datavaddr,
+ (void *)bpage->vaddr, bpage->datacount);
+ /*
+ * pmap_quick_remove_page() will do the writeback
+ * if we have a temporary mapping.
+ */
+ if (tempvaddr == 0) {
+ cpu_dcache_wb_range(
+ bpage->vaddr, bpage->datacount);
+ cpu_l2cache_wb_range(
+ bpage->vaddr, bpage->datacount);
+ }
dmat->bounce_zone->total_bounced++;
}
if (op & BUS_DMASYNC_POSTREAD) {
cpu_dcache_inv_range(bpage->vaddr, bpage->datacount);
cpu_l2cache_inv_range(bpage->vaddr, bpage->datacount);
- if (bpage->datavaddr != 0)
- bcopy((void *)bpage->vaddr,
- (void *)bpage->datavaddr, bpage->datacount);
- else
- physcopyin((void *)bpage->vaddr,
- bpage->dataaddr, bpage->datacount);
+ bcopy((void *)bpage->vaddr,
+ (void *)datavaddr, bpage->datacount);
dmat->bounce_zone->total_bounced++;
}
+ if (tempvaddr != 0)
+ pmap_quick_remove_page(tempvaddr);
}
}
@@ -1246,8 +1317,7 @@
if (map->sync_count) {
end = &map->slist[map->sync_count];
for (sl = &map->slist[0]; sl != end; sl++)
- bus_dmamap_sync_buf(sl->vaddr, sl->datacount, op,
- bufaligned);
+ bus_dmamap_sync_sl(sl, op, bufaligned);
}
drain:
@@ -1445,7 +1515,8 @@
bpage->busaddr |= addr & PAGE_MASK;
}
bpage->datavaddr = vaddr;
- bpage->dataaddr = addr;
+ bpage->datapage = PHYS_TO_VM_PAGE(addr & ~PAGE_MASK);
+ bpage->dataoffs = addr & PAGE_MASK;
bpage->datacount = size;
STAILQ_INSERT_TAIL(&(map->bpages), bpage, links);
return (bpage->busaddr);

File Metadata

Mime Type
text/plain
Expires
Thu, Apr 16, 12:15 PM (1 h, 9 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
31602532
Default Alt Text
D3522.id8379.diff (6 KB)

Event Timeline