Page MenuHomeFreeBSD
Files F151184504

D40166.id126348.diff
No OneTemporary
Actions

D40166.id126348.diff
View Options

diff --git a/sys/kern/subr_intr.c b/sys/kern/subr_intr.c
--- a/sys/kern/subr_intr.c
+++ b/sys/kern/subr_intr.c
@@ -415,6 +415,133 @@
return (EINVAL);
}
+/*
+ * Interrupt source pre_ithread method for MI interrupt framework.
+ */
+static void
+intr_isrc_pre_ithread(void *arg)
+{
+ struct intr_irqsrc *isrc = arg;
+
+ PIC_PRE_ITHREAD(isrc->isrc_dev, isrc);
+}
+
+/*
+ * Interrupt source post_ithread method for MI interrupt framework.
+ */
+static void
+intr_isrc_post_ithread(void *arg)
+{
+ struct intr_irqsrc *isrc = arg;
+
+ PIC_POST_ITHREAD(isrc->isrc_dev, isrc);
+}
+
+/*
+ * Interrupt source post_filter method for MI interrupt framework.
+ */
+static void
+intr_isrc_post_filter(void *arg)
+{
+ struct intr_irqsrc *isrc = arg;
+
+ PIC_POST_FILTER(isrc->isrc_dev, isrc);
+}
+
+/*
+ * Interrupt source assign_cpu method for MI interrupt framework.
+ */
+static int
+intr_isrc_assign_cpu(void *arg, int cpu)
+{
+#ifdef SMP
+ struct intr_irqsrc *isrc = arg;
+ int error;
+
+ mtx_lock(&isrc_table_lock);
+ if (cpu == NOCPU) {
+ CPU_ZERO(&isrc->isrc_cpu);
+ isrc->isrc_flags &= ~INTR_ISRCF_BOUND;
+ } else {
+ CPU_SETOF(cpu, &isrc->isrc_cpu);
+ isrc->isrc_flags |= INTR_ISRCF_BOUND;
+ }
+
+ /*
+ * In NOCPU case, it's up to PIC to either leave ISRC on same CPU or
+ * re-balance it to another CPU or enable it on more CPUs. However,
+ * PIC is expected to change isrc_cpu appropriately to keep us well
+ * informed if the call is successful.
+ */
+ if (irq_assign_cpu) {
+ error = PIC_BIND_INTR(isrc->isrc_dev, isrc);
+ if (error) {
+ CPU_ZERO(&isrc->isrc_cpu);
+ mtx_unlock(&isrc_table_lock);
+ return (error);
+ }
+ }
+ mtx_unlock(&isrc_table_lock);
+ return (0);
+#else
+ return (EOPNOTSUPP);
+#endif
+}
+
+/*
+ * Create interrupt event for interrupt source.
+ */
+static int
+isrc_event_create(struct intr_irqsrc *isrc)
+{
+ struct intr_event *ie;
+ int error;
+
+ error = intr_event_create(&ie, isrc, 0, isrc->isrc_irq,
+ intr_isrc_pre_ithread, intr_isrc_post_ithread, intr_isrc_post_filter,
+ intr_isrc_assign_cpu, "%s:", isrc->isrc_name);
+ if (error)
+ return (error);
+
+ mtx_lock(&isrc_table_lock);
+ /*
+ * Make sure that we do not mix the two ways
+ * how we handle interrupt sources. Let contested event wins.
+ */
+#ifdef INTR_SOLO
+ if (isrc->isrc_filter != NULL || isrc->isrc_event != NULL) {
+#else
+ if (isrc->isrc_event != NULL) {
+#endif
+ mtx_unlock(&isrc_table_lock);
+ intr_event_destroy(ie);
+ return (isrc->isrc_event != NULL ? EBUSY : 0);
+ }
+ isrc->isrc_event = ie;
+ mtx_unlock(&isrc_table_lock);
+
+ return (0);
+}
+
+#ifdef notyet
+/*
+ * Destroy interrupt event for interrupt source.
+ */
+static void
+isrc_event_destroy(struct intr_irqsrc *isrc)
+{
+ struct intr_event *ie;
+
+ mtx_lock(&isrc_table_lock);
+ ie = isrc->isrc_event;
+ isrc->isrc_event = NULL;
+ mtx_unlock(&isrc_table_lock);
+
+ if (ie != NULL)
+ intr_event_destroy(ie);
+}
+#endif
+
/*
* Alloc unique interrupt number (resource handle) for interrupt source.
*
@@ -505,12 +632,18 @@
vsnprintf(isrc->isrc_name, INTR_ISRC_NAMELEN, fmt, ap);
va_end(ap);
+ error = isrc_event_create(isrc);
+ if (error)
+ return (error);
+
mtx_lock(&isrc_table_lock);
error = isrc_alloc_irq(isrc);
if (error != 0) {
+ intr_event_destroy(isrc->isrc_event);
mtx_unlock(&isrc_table_lock);
return (error);
}
+ isrc->isrc_event->ie_irq = isrc->isrc_irq;
/*
* Setup interrupt counters, but not for IPI sources. Those are setup
* later and only for used ones (up to INTR_IPI_COUNT) to not exhaust
@@ -595,131 +728,6 @@
}
#endif
-/*
- * Interrupt source pre_ithread method for MI interrupt framework.
- */
-static void
-intr_isrc_pre_ithread(void *arg)
-{
- struct intr_irqsrc *isrc = arg;
-
- PIC_PRE_ITHREAD(isrc->isrc_dev, isrc);
-}
-
-/*
- * Interrupt source post_ithread method for MI interrupt framework.
- */
-static void
-intr_isrc_post_ithread(void *arg)
-{
- struct intr_irqsrc *isrc = arg;
-
- PIC_POST_ITHREAD(isrc->isrc_dev, isrc);
-}
-
-/*
- * Interrupt source post_filter method for MI interrupt framework.
- */
-static void
-intr_isrc_post_filter(void *arg)
-{
- struct intr_irqsrc *isrc = arg;
-
- PIC_POST_FILTER(isrc->isrc_dev, isrc);
-}
-
-/*
- * Interrupt source assign_cpu method for MI interrupt framework.
- */
-static int
-intr_isrc_assign_cpu(void *arg, int cpu)
-{
-#ifdef SMP
- struct intr_irqsrc *isrc = arg;
- int error;
-
- mtx_lock(&isrc_table_lock);
- if (cpu == NOCPU) {
- CPU_ZERO(&isrc->isrc_cpu);
- isrc->isrc_flags &= ~INTR_ISRCF_BOUND;
- } else {
- CPU_SETOF(cpu, &isrc->isrc_cpu);
- isrc->isrc_flags |= INTR_ISRCF_BOUND;
- }
-
- /*
- * In NOCPU case, it's up to PIC to either leave ISRC on same CPU or
- * re-balance it to another CPU or enable it on more CPUs. However,
- * PIC is expected to change isrc_cpu appropriately to keep us well
- * informed if the call is successful.
- */
- if (irq_assign_cpu) {
- error = PIC_BIND_INTR(isrc->isrc_dev, isrc);
- if (error) {
- CPU_ZERO(&isrc->isrc_cpu);
- mtx_unlock(&isrc_table_lock);
- return (error);
- }
- }
- mtx_unlock(&isrc_table_lock);
- return (0);
-#else
- return (EOPNOTSUPP);
-#endif
-}
-
-/*
- * Create interrupt event for interrupt source.
- */
-static int
-isrc_event_create(struct intr_irqsrc *isrc)
-{
- struct intr_event *ie;
- int error;
-
- error = intr_event_create(&ie, isrc, 0, isrc->isrc_irq,
- intr_isrc_pre_ithread, intr_isrc_post_ithread, intr_isrc_post_filter,
- intr_isrc_assign_cpu, "%s:", isrc->isrc_name);
- if (error)
- return (error);
-
- mtx_lock(&isrc_table_lock);
- /*
- * Make sure that we do not mix the two ways
- * how we handle interrupt sources. Let contested event wins.
- */
-#ifdef INTR_SOLO
- if (isrc->isrc_filter != NULL || isrc->isrc_event != NULL) {
-#else
- if (isrc->isrc_event != NULL) {
-#endif
- mtx_unlock(&isrc_table_lock);
- intr_event_destroy(ie);
- return (isrc->isrc_event != NULL ? EBUSY : 0);
- }
- isrc->isrc_event = ie;
- mtx_unlock(&isrc_table_lock);
-
- return (0);
-}
-#ifdef notyet
-/*
- * Destroy interrupt event for interrupt source.
- */
-static void
-isrc_event_destroy(struct intr_irqsrc *isrc)
-{
- struct intr_event *ie;
-
- mtx_lock(&isrc_table_lock);
- ie = isrc->isrc_event;
- isrc->isrc_event = NULL;
- mtx_unlock(&isrc_table_lock);
-
- if (ie != NULL)
- intr_event_destroy(ie);
-}
-#endif
/*
* Add handler to interrupt source.
*/
@@ -730,12 +738,6 @@
{
int error;
- if (isrc->isrc_event == NULL) {
- error = isrc_event_create(isrc);
- if (error)
- return (error);
- }
-
error = intr_event_add_handler(isrc->isrc_event, name, filter, handler,
arg, intr_priority(flags), flags, cookiep);
if (error == 0) {

File Metadata

Mime Type
text/plain
Expires
Tue, Apr 7, 4:19 PM (3 h, 47 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
31041594
Default Alt Text
D40166.id126348.diff (6 KB)

Event Timeline