Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F148772305
D34703.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
3 KB
Referenced Files
None
Subscribers
None
D34703.diff
View Options
diff --git a/sys/dev/uart/uart_bus_pci.c b/sys/dev/uart/uart_bus_pci.c
--- a/sys/dev/uart/uart_bus_pci.c
+++ b/sys/dev/uart/uart_bus_pci.c
@@ -43,6 +43,7 @@
#include <dev/uart/uart.h>
#include <dev/uart/uart_bus.h>
+#include <dev/uart/uart_cpu.h>
#define DEFAULT_RCLK 1843200
@@ -76,6 +77,11 @@
int regshft;
};
+struct pci_unique_id {
+ uint16_t vendor;
+ uint16_t device;
+};
+
#define PCI_NO_MSI 0x40000000
#define PCI_RID_MASK 0x0000ffff
@@ -214,6 +220,44 @@
return ((id->vendor == vendor && id->device == device) ? id : NULL);
}
+extern SLIST_HEAD(uart_devinfo_list, uart_devinfo) uart_sysdevs;
+
+/* PCI vendor/device pairs of devices guaranteed to be unique on a system. */
+static const struct pci_unique_id pci_unique_devices[] = {
+{ 0x1d0f, 0x8250 } /* Amazon PCI serial device */
+};
+
+/* Match a UART to a console if it's a PCI device known to be unique. */
+static void
+uart_pci_unique_console_match(device_t dev)
+{
+ struct uart_softc *sc;
+ struct uart_devinfo * sysdev;
+ const struct pci_unique_id * id;
+ uint16_t vendor, device;
+
+ sc = device_get_softc(dev);
+ vendor = pci_get_vendor(dev);
+ device = pci_get_device(dev);
+
+ /* Is this a device known to exist only once in a system? */
+ for (id = pci_unique_devices; ; id++) {
+ if (id == &pci_unique_devices[nitems(pci_unique_devices)])
+ return;
+ if (id->vendor == vendor && id->device == device)
+ break;
+ }
+
+ /* If it matches a console, it must be the same device. */
+ SLIST_FOREACH(sysdev, &uart_sysdevs, next) {
+ if (sysdev->pci_info.vendor == vendor &&
+ sysdev->pci_info.device == device) {
+ sc->sc_sysdev = sysdev;
+ sysdev->bas.rclk = sc->sc_bas.rclk;
+ }
+ }
+}
+
static int
uart_pci_probe(device_t dev)
{
@@ -251,6 +295,13 @@
/* Bail out on error. */
if (result > 0)
return (result);
+ /*
+ * If we haven't already matched this to a console, check if it's a
+ * PCI device which is known to only exist once in any given system
+ * and we can match it that way.
+ */
+ if (sc->sc_sysdev == NULL)
+ uart_pci_unique_console_match(dev);
/* Set/override the device description. */
if (id->desc)
device_set_desc(dev, id->desc);
diff --git a/sys/dev/uart/uart_cpu.h b/sys/dev/uart/uart_cpu.h
--- a/sys/dev/uart/uart_cpu.h
+++ b/sys/dev/uart/uart_cpu.h
@@ -52,6 +52,14 @@
extern bus_space_tag_t uart_bus_space_io;
extern bus_space_tag_t uart_bus_space_mem;
+/*
+ * PCI ID used for matching "unique" devices to a console.
+ */
+struct uart_pci_info {
+ uint16_t vendor;
+ uint16_t device;
+};
+
/*
* Console and debug port device info.
*/
@@ -72,6 +80,7 @@
void *cookie; /* Type dependent use. */
struct mtx *hwmtx;
struct uart_softc *sc; /* valid only from start of attach */
+ struct uart_pci_info pci_info;
};
int uart_cpu_eqres(struct uart_bas *, struct uart_bas *);
diff --git a/sys/dev/uart/uart_cpu_acpi.c b/sys/dev/uart/uart_cpu_acpi.c
--- a/sys/dev/uart/uart_cpu_acpi.c
+++ b/sys/dev/uart/uart_cpu_acpi.c
@@ -36,6 +36,8 @@
#include <machine/bus.h>
+#include <dev/pci/pcireg.h>
+
#include <dev/uart/uart.h>
#include <dev/uart/uart_bus.h>
#include <dev/uart/uart_cpu.h>
@@ -182,6 +184,11 @@
(int)spcr->BaudRate);
goto out;
}
+ if (spcr->PciVendorId != PCIV_INVALID &&
+ spcr->PciDeviceId != PCIV_INVALID) {
+ di->pci_info.vendor = spcr->PciVendorId;
+ di->pci_info.device = spcr->PciDeviceId;
+ }
/* Apply device tweaks. */
if ((cd->cd_quirks & UART_F_IGNORE_SPCR_REGSHFT) ==
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 21, 3:43 AM (3 h, 9 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
29999184
Default Alt Text
D34703.diff (3 KB)
Attached To
Mode
D34703: uart(4): Add a concept of "unique" serial devices
Attached
Detach File
Event Timeline
Log In to Comment