Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F148061632
D13845.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
929 B
Referenced Files
None
Subscribers
None
D13845.diff
View Options
Index: sys/cam/cam_periph.c
===================================================================
--- sys/cam/cam_periph.c
+++ sys/cam/cam_periph.c
@@ -1187,10 +1187,16 @@
* scheduler is running in this case, we still need to poll the I/O to
* avoid sleeping waiting for the ccb to complete.
*
- * XXX To avoid locking problems, dumping/polling callers must call
+ * A panic triggered dump stops the scheduler, any callback from the
+ * shutdown_post_sync event will run with the scheduler stopped, but
+ * before we're officially dumping. To avoid hanging in adashutdown
+ * initiated commands (or other similar situations), we have to test for
+ * either SCHEDULER_STOPPED() here as well.
+ *
+ * To avoid locking problems, dumping/polling callers must call
* without a periph lock held.
*/
- must_poll = dumping;
+ must_poll = dumping || SCHEDULER_STOPPED();
ccb->ccb_h.cbfcnp = cam_periph_done;
/*
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Mar 16, 12:17 PM (22 h, 17 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
29770082
Default Alt Text
D13845.diff (929 B)
Attached To
Mode
D13845: Don't hang on crashes with dumps to ada devices.
Attached
Detach File
Event Timeline
Log In to Comment