Page MenuHomeFreeBSD
Files F147316390

D16186.id45035.diff
No OneTemporary
Actions

D16186.id45035.diff
View Options

Index: lib/libnv/Makefile
===================================================================
--- lib/libnv/Makefile
+++ lib/libnv/Makefile
@@ -9,7 +9,10 @@
SHLIB_MAJOR= 0
.PATH: ${SRCTOP}/sys/contrib/libnv ${SRCTOP}/sys/sys
-CFLAGS+=-I${SRCTOP}/sys -I${.CURDIR}
+.ifndef BOOTSTRAPPING
+CFLAGS+=-I${SRCTOP}/sys
+.endif
+CFLAGS+=-I${.CURDIR}
SRCS= cnvlist.c
SRCS+= dnvlist.c
Index: tools/build/mk/Makefile.boot
===================================================================
--- tools/build/mk/Makefile.boot
+++ tools/build/mk/Makefile.boot
@@ -7,3 +7,20 @@
# we do not want to capture dependencies referring to the above
UPDATE_DEPENDFILE= no
+
+# When building host tools we should never pull in headers from the source sys
+# directory to avoid any ABI issues that might cause the built binary to crash.
+# The only exception to this is sys/cddl which is needed by various dtrace tools.
+.info "CFLAGS ERR: ${CFLAGS:N*${SRCTOP}/sys/cddl/compat*:M*${SRCTOP}/sys*}"
+.if !empty(CFLAGS:N*${SRCTOP}/sys/cddl/compat*:M*${SRCTOP}/sys*)
+.error Do not include $${SRCTOP}/sys when building bootstrap tools. \
+ Copy the header to ${WORLDTMP}/legacy in tools/build/Makefile instead. \
+ Error was caused by Makefile in ${.CURDIR}
+.endif
+
+# ${SRCTOP}/include should also never be used to avoid ABI issues
+.if !empty(CFLAGS:M*${SRCTOP}/include*)
+.error Do not include $${SRCTOP}/include when building bootstrap tools. \
+ Copy the header to ${WORLDTMP}/legacy in tools/build/Makefile instead. \
+ Error was caused by Makefile in ${.CURDIR}
+.endif

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 10, 10:05 PM (15 h, 17 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
29515252
Default Alt Text
D16186.id45035.diff (1 KB)

Event Timeline