Page MenuHomeFreeBSD
Files F144389464

D10024.id26305.diff
No OneTemporary
Actions

D10024.id26305.diff
View Options

Index: etc/mtree/BSD.tests.dist
===================================================================
--- etc/mtree/BSD.tests.dist
+++ etc/mtree/BSD.tests.dist
@@ -328,6 +328,8 @@
..
libdevdctl
..
+ libkvm
+ ..
libmp
..
libnv
Index: lib/libkvm/Makefile
===================================================================
--- lib/libkvm/Makefile
+++ lib/libkvm/Makefile
@@ -36,4 +36,8 @@
MLINKS+=kvm_open.3 kvm_close.3 kvm_open.3 kvm_open2.3 kvm_open.3 kvm_openfiles.3
MLINKS+=kvm_read.3 kvm_read2.3 kvm_read.3 kvm_write.3
+.include <src.opts.mk>
+
+SUBDIR.${MK_TESTS}= tests
+
.include <bsd.lib.mk>
Index: lib/libkvm/tests/Makefile
===================================================================
--- /dev/null
+++ lib/libkvm/tests/Makefile
@@ -0,0 +1,14 @@
+# $FreeBSD$
+
+ATF_TESTS_C+= kvm_close_test
+ATF_TESTS_C+= kvm_geterr_test
+ATF_TESTS_C+= kvm_open_test
+ATF_TESTS_C+= kvm_open2_test
+
+LIBADD+= kvm
+
+WARNS?= 6
+
+BINDIR= ${TESTSDIR}
+
+.include <bsd.test.mk>
Index: lib/libkvm/tests/kvm_close_test.c
===================================================================
--- /dev/null
+++ lib/libkvm/tests/kvm_close_test.c
@@ -0,0 +1,56 @@
+/*-
+ * Copyright (c) 2017 Ngie Cooper <ngie@freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <errno.h>
+#include <fcntl.h>
+#include <kvm.h>
+#include <signal.h>
+
+#include <atf-c.h>
+
+ATF_TC(kvm_close_negative_test_NULL);
+ATF_TC_HEAD(kvm_close_negative_test_NULL, tc)
+{
+
+ atf_tc_set_md_var(tc, "descr",
+ "test that kvm_close(NULL) succeeds without error");
+}
+
+ATF_TC_BODY(kvm_close_negative_test_NULL, tc)
+{
+
+ ATF_REQUIRE_ERRNO(EINVAL, kvm_close(NULL) == -1);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+ ATF_TP_ADD_TC(tp, kvm_close_negative_test_NULL);
+
+ return (atf_no_error());
+}
Index: lib/libkvm/tests/kvm_geterr_test.c
===================================================================
--- /dev/null
+++ lib/libkvm/tests/kvm_geterr_test.c
@@ -0,0 +1,55 @@
+/*-
+ * Copyright (c) 2017 Ngie Cooper <ngie@freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <fcntl.h>
+#include <kvm.h>
+#include <signal.h>
+
+#include <atf-c.h>
+
+ATF_TC(kvm_geterr_negative_test_NULL);
+ATF_TC_HEAD(kvm_geterr_negative_test_NULL, tc)
+{
+
+ atf_tc_set_md_var(tc, "descr",
+ "test that kvm_geterr(NULL) returns NULL");
+}
+
+ATF_TC_BODY(kvm_geterr_negative_test_NULL, tc)
+{
+
+ ATF_REQUIRE(kvm_geterr(NULL) == NULL);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+ ATF_TP_ADD_TC(tp, kvm_geterr_negative_test_NULL);
+
+ return (atf_no_error());
+}
Index: lib/libkvm/tests/kvm_open2_test.c
===================================================================
--- /dev/null
+++ lib/libkvm/tests/kvm_open2_test.c
@@ -0,0 +1,110 @@
+/*-
+ * Copyright (c) 2017 Ngie Cooper <ngie@freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <sys/param.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <kvm.h>
+#include <limits.h>
+#include <paths.h>
+#include <signal.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include <atf-c.h>
+
+static char errbuf[_POSIX2_LINE_MAX];
+
+ATF_TC_WITHOUT_HEAD(kvm_open2_negative_test_nonexistent_corefile);
+ATF_TC_BODY(kvm_open2_negative_test_nonexistent_corefile, tc)
+{
+
+ ATF_CHECK(kvm_open2(NULL, "/nonexistent", O_RDONLY, NULL, NULL) == NULL);
+ ATF_CHECK(strlen(errbuf) == 0);
+ ATF_CHECK(kvm_open2(NULL, "/nonexistent", O_RDONLY,
+ errbuf, NULL) == NULL);
+ ATF_CHECK(strlen(errbuf) != 0);
+}
+
+ATF_TC_WITHOUT_HEAD(kvm_open2_negative_test_nonexistent_execfile);
+ATF_TC_BODY(kvm_open2_negative_test_nonexistent_execfile, tc)
+{
+
+ ATF_CHECK(kvm_open2("/nonexistent", _PATH_DEVZERO, O_RDONLY,
+ NULL, NULL) == NULL);
+ ATF_CHECK(strlen(errbuf) == 0);
+ ATF_CHECK(kvm_open2("/nonexistent", _PATH_DEVZERO, O_RDONLY,
+ errbuf, NULL) == NULL);
+ ATF_CHECK(strlen(errbuf) != 0);
+}
+
+ATF_TC(kvm_open2_negative_test_invalid_corefile);
+ATF_TC_HEAD(kvm_open2_negative_test_invalid_corefile, tc)
+{
+
+ atf_tc_set_md_var(tc, "require.user", "root");
+}
+
+ATF_TC_BODY(kvm_open2_negative_test_invalid_corefile, tc)
+{
+ kvm_t *kd;
+
+ atf_utils_create_file("some-file", "this is a text file");
+ kd = kvm_open2(NULL, "some-file", O_RDONLY, errbuf, NULL);
+ ATF_CHECK(strlen(errbuf) != 0);
+ ATF_REQUIRE_MSG(kd == NULL, "kvm_open2 succeeded: %s", errbuf);
+}
+
+ATF_TC(kvm_open2_negative_test_invalid_execfile);
+ATF_TC_HEAD(kvm_open2_negative_test_invalid_execfile, tc)
+{
+
+ atf_tc_set_md_var(tc, "require.user", "root");
+}
+
+ATF_TC_BODY(kvm_open2_negative_test_invalid_execfile, tc)
+{
+ kvm_t *kd;
+
+ kd = kvm_open2(_PATH_DEVNULL, NULL, O_RDONLY, errbuf, NULL);
+ ATF_CHECK(strlen(errbuf) == 0);
+ ATF_REQUIRE_MSG(kd != NULL, "kvm_open2 failed: %s", errbuf);
+ kvm_close(kd);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+ ATF_TP_ADD_TC(tp, kvm_open2_negative_test_invalid_corefile);
+ ATF_TP_ADD_TC(tp, kvm_open2_negative_test_invalid_execfile);
+ ATF_TP_ADD_TC(tp, kvm_open2_negative_test_nonexistent_corefile);
+ ATF_TP_ADD_TC(tp, kvm_open2_negative_test_nonexistent_execfile);
+
+ return (atf_no_error());
+}
Index: lib/libkvm/tests/kvm_open_test.c
===================================================================
--- /dev/null
+++ lib/libkvm/tests/kvm_open_test.c
@@ -0,0 +1,105 @@
+/*-
+ * Copyright (c) 2017 Ngie Cooper <ngie@freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <sys/param.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <kvm.h>
+#include <limits.h>
+#include <paths.h>
+#include <signal.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include <atf-c.h>
+
+ATF_TC_WITHOUT_HEAD(kvm_open_negative_test_nonexistent_corefile);
+ATF_TC_BODY(kvm_open_negative_test_nonexistent_corefile, tc)
+{
+
+ ATF_CHECK(kvm_open(NULL, "/nonexistent", NULL, O_RDONLY, NULL) == NULL);
+ ATF_CHECK(kvm_open(NULL, "/nonexistent", NULL, O_RDONLY,
+ getprogname()) == NULL);
+}
+
+ATF_TC_WITHOUT_HEAD(kvm_open_negative_test_nonexistent_execfile);
+ATF_TC_BODY(kvm_open_negative_test_nonexistent_execfile, tc)
+{
+
+ ATF_CHECK(kvm_open("/nonexistent", _PATH_DEVZERO, NULL, O_RDONLY,
+ NULL) == NULL);
+ ATF_CHECK(kvm_open("/nonexistent", _PATH_DEVZERO, NULL, O_RDONLY,
+ getprogname()) == NULL);
+}
+
+ATF_TC(kvm_open_negative_test_invalid_corefile);
+ATF_TC_HEAD(kvm_open_negative_test_invalid_corefile, tc)
+{
+
+ atf_tc_set_md_var(tc, "require.user", "root");
+}
+
+ATF_TC_BODY(kvm_open_negative_test_invalid_corefile, tc)
+{
+ kvm_t *kd;
+
+ atf_utils_create_file("some-file", "this is a text file");
+ kd = kvm_open(NULL, "some-file", NULL, O_RDONLY, getprogname());
+ ATF_REQUIRE_MSG(kd == NULL, "kvm_open didn't return NULL on failure");
+}
+
+ATF_TC(kvm_open_negative_test_invalid_execfile);
+ATF_TC_HEAD(kvm_open_negative_test_invalid_execfile, tc)
+{
+
+ atf_tc_set_md_var(tc, "require.config", "allow_sysctl_side_effects");
+ atf_tc_set_md_var(tc, "require.user", "root");
+}
+
+ATF_TC_BODY(kvm_open_negative_test_invalid_execfile, tc)
+{
+ kvm_t *kd;
+
+ atf_utils_create_file("some-file", "this is a text file");
+ kd = kvm_open("some-file", NULL, NULL, O_RDONLY, getprogname());
+ ATF_REQUIRE_MSG(kd != NULL, "kvm_open failed: %s", strerror(errno));
+ ATF_REQUIRE(kvm_geterr(kd) != NULL);
+ kvm_close(kd);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+ ATF_TP_ADD_TC(tp, kvm_open_negative_test_invalid_corefile);
+ ATF_TP_ADD_TC(tp, kvm_open_negative_test_invalid_execfile);
+ ATF_TP_ADD_TC(tp, kvm_open_negative_test_nonexistent_corefile);
+ ATF_TP_ADD_TC(tp, kvm_open_negative_test_nonexistent_execfile);
+
+ return (atf_no_error());
+}

File Metadata

Mime Type
text/plain
Expires
Mon, Feb 9, 4:46 AM (1 h, 38 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
28539349
Default Alt Text
D10024.id26305.diff (12 KB)

Event Timeline