Page MenuHomeFreeBSD
Files F143716994

D45826.diff
No OneTemporary
Actions

D45826.diff
View Options

diff --git a/sys/i386/include/pcpu.h b/sys/i386/include/pcpu.h
--- a/sys/i386/include/pcpu.h
+++ b/sys/i386/include/pcpu.h
@@ -108,16 +108,8 @@
/*
* Evaluates to the address of the per-cpu variable name.
*/
-#define __PCPU_PTR(name) __extension__ ({ \
- __pcpu_type(name) *__p; \
- \
- __asm __volatile("movl %%fs:%1,%0; addl %2,%0" \
- : "=r" (__p) \
- : "m" (*(struct pcpu *)(__pcpu_offset(pc_prvspace))), \
- "i" (__pcpu_offset(name))); \
- \
- __p; \
-})
+#define __PCPU_PTR(name) \
+ (&get_pcpu()->name)
/*
* Evaluates to the value of the per-cpu variable name.
@@ -126,14 +118,13 @@
__pcpu_type(name) __res; \
struct __s { \
u_char __b[MIN(sizeof(__res), 4)]; \
- } __s; \
+ }; \
\
if (sizeof(__res) == 1 || sizeof(__res) == 2 || \
sizeof(__res) == 4) { \
- __asm __volatile("mov %%fs:%1,%0" \
- : "=r" (__s) \
- : "m" (*(struct __s *)(__pcpu_offset(name)))); \
- *(struct __s *)(void *)&__res = __s; \
+ __asm __volatile("mov %%fs:%c1,%0" \
+ : "=r" (*(struct __s *)(void *)&__res) \
+ : "i" (__pcpu_offset(name))); \
} else { \
__res = *__PCPU_PTR(name); \
} \
@@ -148,15 +139,16 @@
__pcpu_type(name) __val; \
struct __s { \
u_char __b[MIN(sizeof(__val), 4)]; \
- } __s; \
+ }; \
\
__val = (val); \
if (sizeof(__val) == 1 || sizeof(__val) == 2 || \
sizeof(__val) == 4) { \
- __s = *(struct __s *)(void *)&__val; \
- __asm __volatile("add %1,%%fs:%0" \
- : "=m" (*(struct __s *)(__pcpu_offset(name))) \
- : "r" (__s)); \
+ __asm __volatile("add %1,%%fs:%c0" \
+ : \
+ : "i" (__pcpu_offset(name)), \
+ "r" (*(struct __s *)(void *)&__val) \
+ : "cc", "memory"); \
} else \
*__PCPU_PTR(name) += __val; \
} while (0)
@@ -168,15 +160,16 @@
__pcpu_type(name) __val; \
struct __s { \
u_char __b[MIN(sizeof(__val), 4)]; \
- } __s; \
+ }; \
\
__val = (val); \
if (sizeof(__val) == 1 || sizeof(__val) == 2 || \
sizeof(__val) == 4) { \
- __s = *(struct __s *)(void *)&__val; \
- __asm __volatile("mov %1,%%fs:%0" \
- : "=m" (*(struct __s *)(__pcpu_offset(name))) \
- : "r" (__s)); \
+ __asm __volatile("mov %1,%%fs:%c0" \
+ : \
+ : "i" (__pcpu_offset(name)), \
+ "r" (*(struct __s *)(void *)&__val) \
+ : "memory"); \
} else { \
*__PCPU_PTR(name) = __val; \
} \
@@ -185,9 +178,9 @@
#define get_pcpu() __extension__ ({ \
struct pcpu *__pc; \
\
- __asm __volatile("movl %%fs:%1,%0" \
+ __asm __volatile("movl %%fs:%c1,%0" \
: "=r" (__pc) \
- : "m" (*(struct pcpu *)(__pcpu_offset(pc_prvspace)))); \
+ : "i" (__pcpu_offset(pc_prvspace))); \
__pc; \
})
diff --git a/sys/i386/include/pcpu_aux.h b/sys/i386/include/pcpu_aux.h
--- a/sys/i386/include/pcpu_aux.h
+++ b/sys/i386/include/pcpu_aux.h
@@ -49,8 +49,8 @@
{
struct thread *td;
- __asm("movl %%fs:%1,%0" : "=r" (td)
- : "m" (*(char *)offsetof(struct pcpu, pc_curthread)));
+ __asm("movl %%fs:%c1,%0" : "=r" (td)
+ : "i" (offsetof(struct pcpu, pc_curthread)));
return (td);
}
#define curthread (__curthread())
@@ -60,8 +60,8 @@
{
struct pcb *pcb;
- __asm("movl %%fs:%1,%0" : "=r" (pcb)
- : "m" (*(char *)offsetof(struct pcpu, pc_curpcb)));
+ __asm("movl %%fs:%c1,%0" : "=r" (pcb)
+ : "i" (offsetof(struct pcpu, pc_curpcb)));
return (pcb);
}
#define curpcb (__curpcb())

File Metadata

Mime Type
text/plain
Expires
Sun, Feb 1, 8:38 AM (14 h, 22 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
28323037
Default Alt Text
D45826.diff (3 KB)

Event Timeline