Page MenuHomeFreeBSD
Files F142754072

D19000.diff
No OneTemporary
Actions

D19000.diff
View Options

Index: head/sys/netinet/tcp_input.c
===================================================================
--- head/sys/netinet/tcp_input.c
+++ head/sys/netinet/tcp_input.c
@@ -1470,7 +1470,7 @@
struct tcpcb *tp, int drop_hdrlen, int tlen, uint8_t iptos)
{
int thflags, acked, ourfinisacked, needoutput = 0, sack_changed;
- int rstreason, todrop, win;
+ int rstreason, todrop, win, incforsyn = 0;
uint32_t tiwin;
uint16_t nsegs;
char *s;
@@ -2374,12 +2374,6 @@
if (IS_FASTOPEN(tp->t_flags) && tp->t_tfo_pending) {
tcp_fastopen_decrement_counter(tp->t_tfo_pending);
tp->t_tfo_pending = NULL;
-
- /*
- * Account for the ACK of our SYN prior to
- * regular ACK processing below.
- */
- tp->snd_una++;
}
if (tp->t_flags & TF_NEEDFIN) {
tcp_state_change(tp, TCPS_FIN_WAIT_1);
@@ -2400,6 +2394,13 @@
tcp_timer_activate(tp, TT_KEEP, TP_KEEPIDLE(tp));
}
/*
+ * Account for the ACK of our SYN prior to
+ * regular ACK processing below, except for
+ * simultaneous SYN, which is handled later.
+ */
+ if (SEQ_GT(th->th_ack, tp->snd_una) && !(tp->t_flags & TF_NEEDSYN))
+ incforsyn = 1;
+ /*
* If segment contains data or ACK, will call tcp_reass()
* later; if not, do so now to pass queued data to user.
*/
@@ -2693,6 +2694,15 @@
process_ACK:
INP_WLOCK_ASSERT(tp->t_inpcb);
+ /*
+ * Adjust for the SYN bit in sequence space,
+ * but don't account for it in cwnd calculations.
+ * This is for the SYN_RECEIVED, non-simultaneous
+ * SYN case. SYN_SENT and simultaneous SYN are
+ * treated elsewhere.
+ */
+ if (incforsyn)
+ tp->snd_una++;
acked = BYTES_THIS_ACK(tp, th);
KASSERT(acked >= 0, ("%s: acked unexepectedly negative "
"(tp->snd_una=%u, th->th_ack=%u, tp=%p, m=%p)", __func__,
Index: head/sys/netinet/tcp_stacks/bbr.c
===================================================================
--- head/sys/netinet/tcp_stacks/bbr.c
+++ head/sys/netinet/tcp_stacks/bbr.c
@@ -9326,11 +9326,6 @@
tcp_fastopen_decrement_counter(tp->t_tfo_pending);
tp->t_tfo_pending = NULL;
- /*
- * Account for the ACK of our SYN prior to regular
- * ACK processing below.
- */
- tp->snd_una++;
}
/*
* Make transitions: SYN-RECEIVED -> ESTABLISHED SYN-RECEIVED* ->
@@ -9353,6 +9348,13 @@
if (!IS_FASTOPEN(tp->t_flags))
cc_conn_init(tp);
}
+ /*
+ * Account for the ACK of our SYN prior to
+ * regular ACK processing below, except for
+ * simultaneous SYN, which is handled later.
+ */
+ if (SEQ_GT(th->th_ack, tp->snd_una) && !(tp->t_flags & TF_NEEDSYN))
+ tp->snd_una++;
/*
* If segment contains data or ACK, will call tcp_reass() later; if
* not, do so now to pass queued data to user.
Index: head/sys/netinet/tcp_stacks/rack.c
===================================================================
--- head/sys/netinet/tcp_stacks/rack.c
+++ head/sys/netinet/tcp_stacks/rack.c
@@ -6540,12 +6540,6 @@
if (IS_FASTOPEN(tp->t_flags) && tp->t_tfo_pending) {
tcp_fastopen_decrement_counter(tp->t_tfo_pending);
tp->t_tfo_pending = NULL;
-
- /*
- * Account for the ACK of our SYN prior to
- * regular ACK processing below.
- */
- tp->snd_una++;
}
if (tp->t_flags & TF_NEEDFIN) {
tcp_state_change(tp, TCPS_FIN_WAIT_1);
@@ -6563,6 +6557,13 @@
if (!IS_FASTOPEN(tp->t_flags))
cc_conn_init(tp);
}
+ /*
+ * Account for the ACK of our SYN prior to
+ * regular ACK processing below, except for
+ * simultaneous SYN, which is handled later.
+ */
+ if (SEQ_GT(th->th_ack, tp->snd_una) && !(tp->t_flags & TF_NEEDSYN))
+ tp->snd_una++;
/*
* If segment contains data or ACK, will call tcp_reass() later; if
* not, do so now to pass queued data to user.

File Metadata

Mime Type
text/plain
Expires
Sat, Jan 24, 4:04 AM (6 h, 53 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
27893627
Default Alt Text
D19000.diff (3 KB)

Event Timeline