Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F141029465
D38419.id117233.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
3 KB
Referenced Files
None
Subscribers
None
D38419.id117233.diff
View Options
diff --git a/contrib/elftoolchain/readelf/readelf.c b/contrib/elftoolchain/readelf/readelf.c
--- a/contrib/elftoolchain/readelf/readelf.c
+++ b/contrib/elftoolchain/readelf/readelf.c
@@ -4938,8 +4938,10 @@
return;
}
if (dwarf_attrval_unsigned(die, DW_AT_stmt_list, &offset,
- &de) != DW_DLV_OK)
+ &de) != DW_DLV_OK) {
+ dwarf_dealloc(re->dbg, die, DW_DLA_DIE);
continue;
+ }
length = re->dw_read(d, &offset, 4);
if (length == 0xffffffff) {
@@ -4950,6 +4952,7 @@
if (length > d->d_size - offset) {
warnx("invalid .dwarf_line section");
+ dwarf_dealloc(re->dbg, die, DW_DLA_DIE);
continue;
}
@@ -5147,9 +5150,8 @@
(uintmax_t) line);
p++;
}
-
-
}
+ dwarf_dealloc(re->dbg, die, DW_DLA_DIE);
}
if (ret == DW_DLV_ERROR)
warnx("dwarf_next_cu_header: %s", dwarf_errmsg(de));
@@ -5192,9 +5194,9 @@
printf("%-37s %11s %s\n", "Filename", "Line Number",
"Starting Address");
if (dwarf_srclines(die, &linebuf, &linecount, &de) != DW_DLV_OK)
- continue;
+ goto done;
if (dwarf_srcfiles(die, &srcfiles, &srccount, &de) != DW_DLV_OK)
- continue;
+ goto done;
for (i = 0; i < linecount; i++) {
ln = linebuf[i];
if (dwarf_line_srcfileno(ln, &fn, &de) != DW_DLV_OK)
@@ -5208,6 +5210,8 @@
(uintmax_t) lineaddr);
}
putchar('\n');
+done:
+ dwarf_dealloc(re->dbg, die, DW_DLA_DIE);
}
}
@@ -5840,7 +5844,8 @@
Dwarf_Addr base0;
Dwarf_Half attr;
Dwarf_Signed attr_count, cnt;
- Dwarf_Unsigned off, bytecnt;
+ Dwarf_Unsigned bytecnt;
+ Dwarf_Off off;
int i, j, ret;
if ((ret = dwarf_attrlist(die, &attr_list, &attr_count, &de)) !=
@@ -5857,11 +5862,12 @@
}
if (attr != DW_AT_ranges)
continue;
- if (dwarf_formudata(attr_list[i], &off, &de) != DW_DLV_OK) {
- warnx("dwarf_formudata failed: %s", dwarf_errmsg(de));
+ if (dwarf_global_formref(attr_list[i], &off, &de) != DW_DLV_OK) {
+ warnx("dwarf_global_formref failed: %s",
+ dwarf_errmsg(de));
continue;
}
- if (dwarf_get_ranges(re->dbg, (Dwarf_Off) off, &ranges, &cnt,
+ if (dwarf_get_ranges(re->dbg, off, &ranges, &cnt,
&bytecnt, &de) != DW_DLV_OK)
continue;
base0 = base;
@@ -5900,6 +5906,8 @@
warnx("dwarf_siblingof: %s", dwarf_errmsg(de));
else if (ret == DW_DLV_OK)
dump_dwarf_ranges_foreach(re, ret_die, base);
+
+ dwarf_dealloc(re->dbg, die, DW_DLA_DIE);
}
static void
@@ -6204,7 +6212,7 @@
Dwarf_Small cie_version;
Dwarf_Ptr fde_addr, fde_inst, cie_inst;
char *cie_aug, c;
- int i, eh_frame;
+ int i, ret, eh_frame;
Dwarf_Error de;
printf("\nThe section %s contains:\n\n", s->name);
@@ -6219,10 +6227,13 @@
}
} else if (!strcmp(s->name, ".eh_frame")) {
eh_frame = 1;
- if (dwarf_get_fde_list_eh(re->dbg, &cie_list, &cie_count,
- &fde_list, &fde_count, &de) != DW_DLV_OK) {
- warnx("dwarf_get_fde_list_eh failed: %s",
- dwarf_errmsg(de));
+ ret = dwarf_get_fde_list_eh(re->dbg, &cie_list, &cie_count,
+ &fde_list, &fde_count, &de);
+ if (ret != DW_DLV_OK) {
+ if (ret == DW_DLV_ERROR) {
+ warnx("dwarf_get_fde_list_eh failed: %s",
+ dwarf_errmsg(de));
+ }
return;
}
} else
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Dec 31, 11:12 PM (9 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
27423857
Default Alt Text
D38419.id117233.diff (3 KB)
Attached To
Mode
D38419: readelf(1): fix -wR option, memory leaks, and -wf minor bug
Attached
Detach File
Event Timeline
Log In to Comment