Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F139997652
D18719.id52498.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
2 KB
Referenced Files
None
Subscribers
None
D18719.id52498.diff
View Options
Index: sys/riscv/riscv/pmap.c
===================================================================
--- sys/riscv/riscv/pmap.c
+++ sys/riscv/riscv/pmap.c
@@ -1861,22 +1861,28 @@
void
pmap_protect(pmap_t pmap, vm_offset_t sva, vm_offset_t eva, vm_prot_t prot)
{
- vm_offset_t va_next;
pd_entry_t *l1, *l2;
- pt_entry_t *l3p, l3;
- pt_entry_t entry;
+ pt_entry_t *l3, l3e, mask;
+ vm_page_t m;
+ vm_offset_t va_next;
if ((prot & VM_PROT_READ) == VM_PROT_NONE) {
pmap_remove(pmap, sva, eva);
return;
}
- if ((prot & VM_PROT_WRITE) == VM_PROT_WRITE)
+ if ((prot & (VM_PROT_WRITE | VM_PROT_EXECUTE)) ==
+ (VM_PROT_WRITE | VM_PROT_EXECUTE))
return;
+ mask = 0;
+ if ((prot & VM_PROT_WRITE) == 0)
+ mask |= PTE_W | PTE_D;
+ if ((prot & VM_PROT_EXECUTE) == 0)
+ mask |= PTE_X;
+
PMAP_LOCK(pmap);
for (; sva < eva; sva = va_next) {
-
l1 = pmap_l1(pmap, sva);
if (pmap_load(l1) == 0) {
va_next = (sva + L1_SIZE) & ~L1_OFFSET;
@@ -1890,9 +1896,7 @@
va_next = eva;
l2 = pmap_l1_to_l2(l1, sva);
- if (l2 == NULL)
- continue;
- if (pmap_load(l2) == 0)
+ if (l2 == NULL || pmap_load(l2) == 0)
continue;
if ((pmap_load(l2) & PTE_RX) != 0)
continue;
@@ -1900,16 +1904,22 @@
if (va_next > eva)
va_next = eva;
- for (l3p = pmap_l2_to_l3(l2, sva); sva != va_next; l3p++,
+ for (l3 = pmap_l2_to_l3(l2, sva); sva != va_next; l3++,
sva += L3_SIZE) {
- l3 = pmap_load(l3p);
- if ((l3 & PTE_V) != 0) {
- entry = pmap_load(l3p);
- entry &= ~PTE_W;
- pmap_store(l3p, entry);
- /* XXX: Use pmap_invalidate_range */
- pmap_invalidate_page(pmap, sva);
+ l3e = pmap_load(l3);
+retry:
+ if ((l3e & PTE_V) == 0)
+ continue;
+ if ((prot & VM_PROT_WRITE) == 0 &&
+ (l3e & (PTE_SW_MANAGED | PTE_D)) ==
+ (PTE_SW_MANAGED | PTE_D)) {
+ m = PHYS_TO_VM_PAGE(PTE_TO_PHYS(l3e));
+ vm_page_dirty(m);
}
+ if (!atomic_fcmpset_long(l3, &l3e, l3e & ~mask))
+ goto retry;
+ /* XXX: Use pmap_invalidate_range */
+ pmap_invalidate_page(pmap, sva);
}
}
PMAP_UNLOCK(pmap);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 19, 7:46 PM (1 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
27086803
Default Alt Text
D18719.id52498.diff (2 KB)
Attached To
Mode
D18719: Fix some issues with pmap_protect().
Attached
Detach File
Event Timeline
Log In to Comment