Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F136989188
D14848.id40733.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D14848.id40733.diff
View Options
Index: sys/dev/nxge/if_nxge.c
===================================================================
--- sys/dev/nxge/if_nxge.c
+++ sys/dev/nxge/if_nxge.c
@@ -1364,10 +1364,16 @@
xge_ioctl_stats(xge_lldev_t *lldev, struct ifreq *ifreqp)
{
xge_hal_status_e status = XGE_HAL_OK;
- char *data = (char *)ifreqp->ifr_data;
+ char tmpdata;
+ char *data;
void *info = NULL;
int retValue = EINVAL;
+ tmpdata = fubyte(ifreqp->ifr_data);
+ if (tmpdata == -1)
+ return (EFAULT);
+ data = &tmpdata;
+
switch(*data) {
case XGE_QUERY_STATS:
mtx_lock(&lldev->mtx_drv);
@@ -1518,11 +1524,18 @@
int
xge_ioctl_registers(xge_lldev_t *lldev, struct ifreq *ifreqp)
{
- xge_register_t *data = (xge_register_t *)ifreqp->ifr_data;
+ xge_register_t tmpdata;
+ xge_register_t *data;
xge_hal_status_e status = XGE_HAL_OK;
int retValue = EINVAL, offset = 0, index = 0;
+ int error;
u64 val64 = 0;
+ error = copyin(ifreqp->ifr_data, &tmpdata, sizeof(tmpdata));
+ if (error != 0)
+ return (error);
+ data = &tmpdata;
+
/* Reading a register */
if(strcmp(data->option, "-r") == 0) {
data->value = 0x0000;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Nov 21, 10:31 PM (5 h, 3 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
25817291
Default Alt Text
D14848.id40733.diff (1 KB)
Attached To
Mode
D14848: Don't access userspace directly from the kernel in nxge(4).
Attached
Detach File
Event Timeline
Log In to Comment