Page MenuHomeFreeBSD
Files F136601762

D9184.id24006.diff
No OneTemporary
Actions

D9184.id24006.diff
View Options

Index: devel/qt4-linguist/files/patch-tools__linguist__linguist__messagemodel.cpp
===================================================================
--- /dev/null
+++ devel/qt4-linguist/files/patch-tools__linguist__linguist__messagemodel.cpp
@@ -0,0 +1,14 @@
+Nonsensical pointer comparison caught by Clang 4.0. findMessage()
+returns NULL on not-found.
+
+--- tools/linguist/linguist/messagemodel.cpp.orig 2017-01-14 22:08:09.527076000 +0100
++++ tools/linguist/linguist/messagemodel.cpp 2017-01-14 22:08:34.096069000 +0100
+@@ -183,7 +183,7 @@
+ if (ContextItem *c = one->findContext(oc->context())) {
+ for (int j = 0; j < oc->messageCount(); ++j) {
+ MessageItem *m = oc->messageItem(j);
+- if (c->findMessage(m->text(), m->comment()) >= 0)
++ if (c->findMessage(m->text(), m->comment()) != 0)
+ ++inBoth;
+ }
+ }

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 19, 1:12 PM (9 h, 11 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
25635362
Default Alt Text
D9184.id24006.diff (925 B)

Event Timeline