Page MenuHomeFreeBSD
Files F133076836

D20753.id59018.diff
No OneTemporary
Actions

D20753.id59018.diff
View Options

Index: vm_map.c
===================================================================
--- vm_map.c
+++ vm_map.c
@@ -2454,6 +2454,7 @@
vm_object_t obj;
struct ucred *cred;
vm_prot_t old_prot;
+ int rv;
if (start == end)
return (KERN_SUCCESS);
@@ -2508,10 +2509,13 @@
}
/*
- * Do an accounting pass for private read-only mappings that
- * now will do cow due to allowed write (e.g. debugger sets
- * breakpoint on text segment)
+ * Do an accounting pass for private read-only mappings that now will
+ * do cow due to allowed write (e.g. debugger sets breakpoint on text
+ * segment). If too little swap space is available for backing the
+ * copied pages, break the loop early and let the next loop simplify
+ * entries, since some may mergeable.
*/
+ rv = KERN_SUCCESS;
vm_map_clip_start(map, entry, start);
for (current = entry; current->start < end; current = current->next) {
@@ -2529,8 +2533,8 @@
if (obj == NULL || (current->eflags & MAP_ENTRY_NEEDS_COPY)) {
if (!swap_reserve(current->end - current->start)) {
- vm_map_unlock(map);
- return (KERN_RESOURCE_SHORTAGE);
+ rv = KERN_RESOURCE_SHORTAGE;
+ break;
}
crhold(cred);
current->cred = cred;
@@ -2553,8 +2557,8 @@
obj, current));
if (!swap_reserve(ptoa(obj->size))) {
VM_OBJECT_WUNLOCK(obj);
- vm_map_unlock(map);
- return (KERN_RESOURCE_SHORTAGE);
+ rv = KERN_RESOURCE_SHORTAGE;
+ break;
}
crhold(cred);
@@ -2564,11 +2568,14 @@
}
/*
- * Go back and fix up protections. [Note that clipping is not
- * necessary the second time.]
+ * If enough swap space was available, go back and fix up
+ * protections. [Note that clipping is not necessary the second time.]
+ * Otherwise, just simplify entries, since some may have been modified.
*/
- for (current = entry; current->start < end; current = current->next) {
- if ((current->eflags & MAP_ENTRY_GUARD) != 0)
+ for (current = entry; current->start < end;
+ vm_map_simplify_entry(map, current), current = current->next) {
+ if (rv != KERN_SUCCESS ||
+ (current->eflags & MAP_ENTRY_GUARD) != 0)
continue;
old_prot = current->protection;
@@ -2603,10 +2610,9 @@
current->protection & MASK(current));
#undef MASK
}
- vm_map_simplify_entry(map, current);
}
vm_map_unlock(map);
- return (KERN_SUCCESS);
+ return (rv);
}
/*

File Metadata

Mime Type
text/plain
Expires
Thu, Oct 23, 6:32 PM (14 h, 5 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
24098597
Default Alt Text
D20753.id59018.diff (2 KB)

Event Timeline