Page MenuHomeFreeBSD
Files F107787046

D7534.id19361.diff
No OneTemporary
Actions

D7534.id19361.diff
View Options

Index: CHANGES
===================================================================
--- CHANGES
+++ CHANGES
@@ -10,6 +10,14 @@
All ports committers are allowed to commit to this file.
+20160816:
+AUTHOR: amdmi3@FreeBSD.org
+
+ Verbose build logs are now preferred and enabled by default for cmake and
+ ninja. Other ports are strongly advised to switch to verbose logs where
+ possible. For instance, GNU_CONFIGURE-using ports plagued with silent logs
+ may be fixed with CONFIGURE_ARGS+= --disable-silent-rules
+
20160803:
AUTHOR: mat@FreeBSD.org
Index: Mk/Uses/cmake.mk
===================================================================
--- Mk/Uses/cmake.mk
+++ Mk/Uses/cmake.mk
@@ -12,8 +12,6 @@
# Additional variables that affect cmake behaviour:
#
# User defined variables:
-# CMAKE_VERBOSE - Enable verbose build output
-# Default: not set, unless BATCH or PACKAGE_BUILDING is defined
# CMAKE_NOCOLOR - Disable colour build output
# Default: not set, unless BATCH or PACKAGE_BUILDING is defined
# CMAKE_NINJA - Use ninja instead of make(1)
@@ -80,18 +78,15 @@
-DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \
-DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" \
-DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES \
- -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=YES
+ -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=YES \
+ -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON
CMAKE_INSTALL_PREFIX?= ${PREFIX}
.if defined(BATCH) || defined(PACKAGE_BUILDING)
-CMAKE_VERBOSE= yes
CMAKE_NOCOLOR= yes
.endif
-.if defined(CMAKE_VERBOSE)
-CMAKE_ARGS+= -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON
-.endif
.if defined(CMAKE_NOCOLOR)
CMAKE_ARGS+= -DCMAKE_COLOR_MAKEFILE:BOOL=OFF
.endif
Index: Mk/Uses/ninja.mk
===================================================================
--- Mk/Uses/ninja.mk
+++ Mk/Uses/ninja.mk
@@ -5,9 +5,6 @@
# Feature: ninja
# Usage: USES=ninja
#
-# User defined variables:
-# NINJA_VERBOSE - Enable verbose output.
-#
# MAINTAINER: portmgr@FreeBSD.org
.if !defined(_INCLUDE_USES_NINJA_MK)
@@ -17,9 +14,7 @@
IGNORE= Incorrect 'USES+= ninja:${ninja_ARGS}' ninja takes no arguments
.endif
-.if defined(NINJA_VERBOSE)
MAKE_ARGS+= -v
-.endif
BUILD_DEPENDS+= ninja:devel/ninja

File Metadata

Mime Type
text/plain
Expires
Sun, Jan 19, 4:58 AM (5 h, 1 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
15924822
Default Alt Text
D7534.id19361.diff (2 KB)

Event Timeline