Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F105770746
D28357.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
2 KB
Referenced Files
None
Subscribers
None
D28357.diff
View Options
diff --git a/sys/netinet/tcp_ratelimit.h b/sys/netinet/tcp_ratelimit.h
--- a/sys/netinet/tcp_ratelimit.h
+++ b/sys/netinet/tcp_ratelimit.h
@@ -44,8 +44,6 @@
const struct tcp_rate_set *ptbl; /* Pointer to parent table */
struct m_snd_tag *tag; /* Send tag if needed (chelsio) */
uint64_t rate; /* Rate we get in Bytes per second (Bps) */
- uint64_t using; /* Temporary -- rrs remove */
- uint64_t rs_num_enobufs;
uint32_t time_between; /* Time-Gap between packets at this rate */
uint32_t flags;
};
diff --git a/sys/netinet/tcp_ratelimit.c b/sys/netinet/tcp_ratelimit.c
--- a/sys/netinet/tcp_ratelimit.c
+++ b/sys/netinet/tcp_ratelimit.c
@@ -372,17 +372,6 @@
OID_AUTO, "rate", CTLFLAG_RD,
&rs->rs_rlt[i].rate, 0,
"Rate in bytes per second");
- SYSCTL_ADD_U64(&rs->sysctl_ctx,
- SYSCTL_CHILDREN(rl_rate_num),
- OID_AUTO, "using", CTLFLAG_RD,
- &rs->rs_rlt[i].using, 0,
- "Number of flows using");
- SYSCTL_ADD_U64(&rs->sysctl_ctx,
- SYSCTL_CHILDREN(rl_rate_num),
- OID_AUTO, "enobufs", CTLFLAG_RD,
- &rs->rs_rlt[i].rs_num_enobufs, 0,
- "Number of enobufs logged on this rate");
-
}
}
#endif
@@ -678,8 +667,6 @@
*/
rs->rs_rlt[i].ptbl = rs;
rs->rs_rlt[i].tag = NULL;
- rs->rs_rlt[i].using = 0;
- rs->rs_rlt[i].rs_num_enobufs = 0;
/*
* Calculate the time between.
*/
@@ -1076,28 +1063,16 @@
static void
rl_increment_using(const struct tcp_hwrate_limit_table *rte)
{
- struct tcp_hwrate_limit_table *decon_rte;
-
- decon_rte = __DECONST(struct tcp_hwrate_limit_table *, rte);
- atomic_add_long(&decon_rte->using, 1);
}
static void
rl_decrement_using(const struct tcp_hwrate_limit_table *rte)
{
- struct tcp_hwrate_limit_table *decon_rte;
-
- decon_rte = __DECONST(struct tcp_hwrate_limit_table *, rte);
- atomic_subtract_long(&decon_rte->using, 1);
}
void
tcp_rl_log_enobuf(const struct tcp_hwrate_limit_table *rte)
{
- struct tcp_hwrate_limit_table *decon_rte;
-
- decon_rte = __DECONST(struct tcp_hwrate_limit_table *, rte);
- atomic_add_long(&decon_rte->rs_num_enobufs, 1);
}
/*
@@ -1214,9 +1189,11 @@
rte = NULL;
} else {
KASSERT((inp->inp_snd_tag != NULL) ,
- ("Setup rate has no snd_tag inp:%p rte:%p rate:%lu rs:%p",
- inp, rte, rte->rate, rs));
+ ("Setup rate has no snd_tag inp:%p rte:%p rate:%llu rs:%p",
+ inp, rte, (unsigned long long)rte->rate, rs));
+#ifdef INET
counter_u64_add(rate_limit_new, 1);
+#endif
}
}
if (rte) {
@@ -1462,8 +1439,11 @@
if (error)
*error = err;
return (NULL);
- } else
+ } else {
+#ifdef INET
counter_u64_add(rate_limit_chg, 1);
+#endif
+ }
if (error)
*error = 0;
tp->t_pacing_rate = nrte->rate;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 11:21 AM (18 h, 16 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
15540813
Default Alt Text
D28357.diff (2 KB)
Attached To
Mode
D28357: Update the tcp_ratelimit code to finally work right :)
Attached
Detach File
Event Timeline
Log In to Comment