Page MenuHomeFreeBSD

Update to 1.8.0
ClosedPublic

Authored by dereks_lifeofadishwasher.com on Feb 27 2017, 3:39 AM.

Details

Reviewers
adamw
Summary
  • Update to 1.8.0 o Compressed Folders is now part of main line

o https://dev.mutt.org/hg/mutt/file/stable/UPDATING#l11

  • Fix missing lib depends with libgpg-errors and libassuan
  • Move Header Cache to a BSD ports single radio
  • Remove redundent sidebar var
  • VVV updated to 1.8.0
  • GREETING updated to 1.7.2
  • extra-patch-parent-child-match converted to a makepatch
Test Plan

Built with all possible options and iternations of header caches

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7890
Build 8030: arc lint + arc unit

Event Timeline

dereks_lifeofadishwasher.com retitled this revision from to Update to 1.8.0.
dereks_lifeofadishwasher.com updated this object.
dereks_lifeofadishwasher.com edited the test plan for this revision. (Show Details)
adamw added inline comments.Feb 27 2017, 4:56 AM
mail/mutt/Makefile
212

There's a _PLIST_FILES helper; this should be COMPRESSED_FOLDERS_PLIST_FILES.

293

Why is this (and pre-configure) a ::? Can they just be a normal :?

dereks_lifeofadishwasher.com marked an inline comment as done.
  • Updated to use the COMPRESSED_FOLDER_PLIST_FILES helper.
  • post-patch:: can be changed to a : since there's a single post-patch creation script.

It seems possible that pre-configure:: could be converted to a : if "CONFIGURE_SED" is moved to a _VAR helper.

mail/mutt/Makefile
293

I don't know if I fully understand the difference between : vs :: for source less targets. But my understanding according to the make's man page is a source less :: will always be recreated. If so it doesn't seem necessary.

Also, if so should all instances of :: be changed to :?

It seems that GNU make's :: is required if you want to create multiple targets of the same name. Were these added in that manner out of confusion - this is just a speculation?

doh. The inline "I don't know if I fully understand..." was held waiting for me to submit "Leap Into Action!" This was initially entered Sun 2/27. I think that would explain why I didn't see any reply about it.

adamw added inline comments.Mar 4 2017, 3:16 PM
mail/mutt/Makefile
293

Only where the target is only defined once, which in this case is just post-patch, so AFAIK it's right now that you've changed post-patch.

adamw accepted this revision.Mar 4 2017, 4:05 PM
adamw edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2017, 4:05 PM
adamw closed this revision.Mar 4 2017, 4:05 PM

Committed in r435416. Thanks, Derek.